diff --git a/.codespellignore b/.codespellignore index 58218f7774..8a34eeef24 100644 --- a/.codespellignore +++ b/.codespellignore @@ -3,4 +3,5 @@ unit jsonplaceholder crate implementor -implementors \ No newline at end of file +implementors +alo \ No newline at end of file diff --git a/.github/workflows/spell-check.yml b/.github/workflows/spell-check.yml index 7f0f9db568..7e5708b558 100644 --- a/.github/workflows/spell-check.yml +++ b/.github/workflows/spell-check.yml @@ -25,6 +25,6 @@ jobs: - uses: actions/checkout@v4 - uses: codespell-project/actions-codespell@v2 with: - skip: .git,*/package.json,*/package-lock.json,*.lock,.github,.vscode,assets + skip: ".git,*/package.json,*/package-lock.json,*.lock,.github,.vscode,assets, *.snap" ignore_words_file: .codespellignore check_hidden: false diff --git a/src/cli/runtime/http.rs b/src/cli/runtime/http.rs index 8b1ec3baa7..070be612bb 100644 --- a/src/cli/runtime/http.rs +++ b/src/cli/runtime/http.rs @@ -200,7 +200,7 @@ mod tests { let header_serv = server.mock(|when, then| { when.method(httpmock::Method::GET).path("/test"); - then.status(200).body("Alo"); + then.status(200).body("Hello"); }); let native_http = NativeHttp::init(&Default::default(), &Default::default()); @@ -216,7 +216,7 @@ mod tests { assert!(result.is_ok()); let response = result.unwrap(); assert_eq!(response.status, reqwest::StatusCode::OK); - assert_eq!(response.body, Bytes::from("Alo")); + assert_eq!(response.body, Bytes::from("Hello")); header_serv.assert(); } diff --git a/src/grpc/protobuf.rs b/src/grpc/protobuf.rs index 4175ce73ad..8c2bf5efc0 100644 --- a/src/grpc/protobuf.rs +++ b/src/grpc/protobuf.rs @@ -227,9 +227,9 @@ impl ProtobufOperation { ) })?; - let mut ser = serde_json::Serializer::new(vec![]); - message.serialize_with_options(&mut ser, &self.serialize_options)?; - let json = serde_json::from_slice::(ser.into_inner().as_ref())?; + let mut serializer = serde_json::Serializer::new(vec![]); + message.serialize_with_options(&mut serializer, &self.serialize_options)?; + let json = serde_json::from_slice::(serializer.into_inner().as_ref())?; Ok(json) } diff --git a/tests/core/snapshots/test-enum-default.md_0.snap b/tests/core/snapshots/test-enum-default.md_0.snap index d177f0791f..84d79bf621 100644 --- a/tests/core/snapshots/test-enum-default.md_0.snap +++ b/tests/core/snapshots/test-enum-default.md_0.snap @@ -21,7 +21,7 @@ expression: response }, { "id": 3, - "foo": "ND" + "foo": "NOT_DEFINED" } ] } diff --git a/tests/core/snapshots/test-enum-default.md_client.snap b/tests/core/snapshots/test-enum-default.md_client.snap index 45aa5dcbe8..8af62223b3 100644 --- a/tests/core/snapshots/test-enum-default.md_client.snap +++ b/tests/core/snapshots/test-enum-default.md_client.snap @@ -27,7 +27,7 @@ type Query { enum Status { DRAFT - ND + NOT_DEFINED PUBLISHED } diff --git a/tests/core/snapshots/test-enum-default.md_merged.snap b/tests/core/snapshots/test-enum-default.md_merged.snap index 0225e1e26a..f5750f210c 100644 --- a/tests/core/snapshots/test-enum-default.md_merged.snap +++ b/tests/core/snapshots/test-enum-default.md_merged.snap @@ -8,7 +8,7 @@ schema @server(port: 8080) @upstream(baseURL: "http://localhost:50051", batch: { enum Status { DRAFT - ND + NOT_DEFINED PUBLISHED } diff --git a/tests/core/snapshots/test-scalars.md_0.snap b/tests/core/snapshots/test-scalars.md_0.snap index f9589339d0..3eab7453aa 100644 --- a/tests/core/snapshots/test-scalars.md_0.snap +++ b/tests/core/snapshots/test-scalars.md_0.snap @@ -9,7 +9,7 @@ expression: response }, "body": { "data": { - "email": "alo@valid.com" + "email": "hello@valid.com" } } } diff --git a/tests/execution/test-enum-default.md b/tests/execution/test-enum-default.md index 68f059b55f..ce8a1e161f 100644 --- a/tests/execution/test-enum-default.md +++ b/tests/execution/test-enum-default.md @@ -8,23 +8,23 @@ import "google/protobuf/empty.proto"; package news; enum Status { - PUBLISHED = 0; - DRAFT = 1; - ND = 2; + PUBLISHED = 0; + DRAFT = 1; + NOT_DEFINED = 2; } message News { - int32 id = 1; - Status foo = 5; + int32 id = 1; + Status foo = 5; } service NewsService { - rpc GetAllNews (google.protobuf.Empty) returns (NewsList) {} + rpc GetAllNews (google.protobuf.Empty) returns (NewsList) {} } message NewsList { - repeated News news = 1; + repeated News news = 1; } ``` @@ -44,7 +44,7 @@ type Query { enum Status { PUBLISHED DRAFT - ND + NOT_DEFINED } type News { diff --git a/tests/execution/test-scalars.md b/tests/execution/test-scalars.md index 86d16e2a13..0abb15f656 100644 --- a/tests/execution/test-scalars.md +++ b/tests/execution/test-scalars.md @@ -23,7 +23,7 @@ type Query { - method: POST url: http://localhost:8000/graphql body: - query: '{ email(value: "alo@valid.com") }' + query: '{ email(value: "hello@valid.com") }' - method: POST url: http://localhost:8000/graphql body: @@ -44,7 +44,7 @@ type Query { - method: POST url: http://localhost:8000/graphql body: - query: '{ email(value: "alo@invalid") }' + query: '{ email(value: "hello@invalid") }' - method: POST url: http://localhost:8000/graphql body: @@ -61,5 +61,5 @@ type Query { - method: POST url: http://localhost:8000/graphql body: - query: '{ url(value: "invalidhost") }' + query: '{ url(value: "invalid_host") }' ```