Skip to content

Commit d7ba847

Browse files
authored
Merge pull request #100 from vsimko/master
incremented version and updated authors
2 parents 3dfc1f3 + edc6673 commit d7ba847

File tree

5 files changed

+19
-11
lines changed

5 files changed

+19
-11
lines changed

DESCRIPTION

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
Package: corrplot
22
Type: Package
33
Title: Visualization of a Correlation Matrix
4-
Version: 0.82
5-
Date: 2017-02-09
6-
Author: Taiyun Wei, Viliam Simko
4+
Version: 0.83
5+
Date: 2017-08-24
6+
Author: Taiyun Wei and Viliam Simko with contributions by Michael Levy,
7+
Yihui Xie, Yan Jin and jeffzemla
78
Suggests:
89
knitr,
910
RColorBrewer,

R/corrplot.R

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@
217217
#'
218218
#' @author Taiyun Wei (weitaiyun@@gmail.com)
219219
#' @author Viliam Simko (viliam.simko@@gmail.com)
220+
#' @author Michael Levy (michael.levy@@healthcatalyst.com)
220221
#'
221222
#' @note \code{Cairo} and \code{cairoDevice} packages is strongly recommended to
222223
#' produce high-quality PNG, JPEG, TIFF bitmap files, especially for that
@@ -799,12 +800,13 @@ corrplot <- function(corr,
799800
if (insig == "label_sig") {
800801

801802
# Unless another character is specified, mark sig with *
802-
if(!is.character(pch))
803+
if (!is.character(pch))
803804
pch <- "*"
804805

805-
place_points <- function(sig.locs, point)
806+
place_points <- function(sig.locs, point) {
806807
text(pos.pNew[,1][sig.locs], pos.pNew[,2][sig.locs],
807808
labels = point, col = pch.col, cex = pch.cex, lwd = 2)
809+
}
808810

809811
if (length(sig.level) == 1) {
810812
place_points(sig.locs = which(pNew < sig.level), point = pch)
@@ -814,17 +816,19 @@ corrplot <- function(corr,
814816
for (i in seq_along(sig.level)) {
815817
iter <- l + 1 - i
816818
pchTmp <- paste(rep(pch, i), collapse = "")
817-
if(i == length(sig.level)) {
819+
if (i == length(sig.level)) {
818820
locs <- which(pNew < sig.level[iter])
819-
if (length(locs))
821+
if (length(locs)) {
820822
place_points(sig.locs = locs, point = pchTmp)
823+
}
821824
} else {
822825
locs <- which(pNew < sig.level[iter] & pNew > sig.level[iter - 1])
823-
if(length(locs))
826+
if (length(locs)) {
824827
place_points(sig.locs = locs, point = pchTmp)
828+
}
825829
}
826-
827830
}
831+
828832
}
829833

830834
} else {

inst/CITATION

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
PKG <- "corrplot"
22
VERSION <- packageVersion(PKG)
33
TITLE <- packageDescription(PKG, fields = "Title")
4-
AUTHORS <- packageDescription(PKG, fields = "Author")
4+
AUTHORS <- gsub("\\s+with contrib.*", " et al.",
5+
packageDescription(PKG, fields = "Author"))
56
URL <- packageDescription(PKG, fields = "URL")
67
YEAR <- strftime(packageDescription(PKG, fields = "Date"), "%Y")
78

man/corrplot.Rd

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/test-corrplot.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ test_that("Issue #76: separate `col` parameters corrplot.mixed", {
216216
upper = "number", upper.col = "black"))
217217
})
218218

219-
test_that("Mark significant correlations", {
219+
test_that("Issue #99: Mark significant correlations", {
220220
M <- cor(mtcars)
221221
fakepmat <- 1 - abs(M) ^ .2 # Hmisc::rcorr provides a p-value matrix, but
222222
# don't want to introduce the dependency

0 commit comments

Comments
 (0)