From 04426e0e694723c8e315d2694eb40bb994aeb0ba Mon Sep 17 00:00:00 2001
From: alpharush <0xalpharush@protonmail.com>
Date: Mon, 29 Jan 2024 15:43:14 -0600
Subject: [PATCH] Fix/iterative update (#2206)

* use iterative algo to prevent exceeding recursion limit

* proper fixpoint
---
 slither/solc_parsing/declarations/function.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/slither/solc_parsing/declarations/function.py b/slither/solc_parsing/declarations/function.py
index 59940ec1cd..c1b94661d1 100644
--- a/slither/solc_parsing/declarations/function.py
+++ b/slither/solc_parsing/declarations/function.py
@@ -1106,11 +1106,13 @@ def _parse_unchecked_block(self, block: Dict, node: NodeSolc, scope):
         return node
 
     def _update_reachability(self, node: Node) -> None:
-        if node.is_reachable:
-            return
-        node.set_is_reachable(True)
-        for son in node.sons:
-            self._update_reachability(son)
+        worklist = [node]
+        while worklist:
+            current = worklist.pop()
+            # fix point
+            if not current.is_reachable:
+                current.set_is_reachable(True)
+                worklist.extend(current.sons)
 
     def _parse_cfg(self, cfg: Dict) -> None: