Skip to content

Commit ecd937f

Browse files
committed
Move setup usage of factory to beforeEach blocks
1 parent 63d2e67 commit ecd937f

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

test/api/users/listUsers.spec.js

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,16 @@ const { expect } = require('chai');
44

55
describe('API :: GET /api/users', () => {
66
context('when there are users', () => {
7+
beforeEach(() => {
8+
return factory.createMany('user', 2, [
9+
{ name: 'First' },
10+
{ name: 'Second' }
11+
]);
12+
});
13+
714
it('return success with array of users', () => {
8-
return factory
9-
.createMany('user', 2, [
10-
{ name: 'First' },
11-
{ name: 'Second' }
12-
])
13-
.then(() => request().get('/api/users')
14-
.expect(200))
15+
return request().get('/api/users')
16+
.expect(200)
1517
.then(({ body }) => {
1618
expect(body).to.have.lengthOf(2);
1719

test/infra/user/SequelizeUsersRepository.spec.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,17 @@ const { User: UserModel } = require('src/infra/database/models');
66

77
describe('Infra :: User :: SequelizeUsersRepository', () => {
88
describe('#getAll', () => {
9+
beforeEach(() => {
10+
return factory.createMany('user', 2, [
11+
{ name: 'User 1' },
12+
{ name: 'User 2' }
13+
]);
14+
});
15+
916
it('returns all users from the database', () => {
1017
const repository = new SequelizeUsersRepository({ UserModel });
1118

12-
return factory
13-
.createMany('user', 2, [
14-
{ name: 'User 1' },
15-
{ name: 'User 2' }
16-
])
17-
.then(() => repository.getAll())
19+
return repository.getAll()
1820
.then((users) => {
1921
expect(users).to.have.lengthOf(2);
2022

0 commit comments

Comments
 (0)