Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reversed Heuristic and Exhaustive buttons #54

Closed
hiverniaa opened this issue Mar 6, 2025 · 2 comments · Fixed by #55
Closed

Reversed Heuristic and Exhaustive buttons #54

hiverniaa opened this issue Mar 6, 2025 · 2 comments · Fixed by #55
Assignees
@yuqisun

Comments

@hiverniaa
Copy link

The behavior of the UI seems wrong when choosing which algorithm to use for mapping : when selecting "Heuristic" in the GUI, the heuristicMapping parameter in the param.json file in the build/kernel directory gets updated to false, and vice-versa.

I believe this is not the intended behavior, since when run through a script in the command line, the mapping process prints [heuristic] when heuristicMapping is set to true, and [exhaustive] when set to false.

The issue is present in the Docker image, and I think it was not fixed in later modifications of CGRA-Flow.
@hiverniaa hiverniaa mentioned this issue Mar 6, 2025
Open
@yuqisun yuqisun self-assigned this Mar 6, 2025
yuqisun added a commit to yuqisun/CGRA-Flow that referenced this issue Mar 6, 2025
@yuqisun
Reversed Heuristic and Exhaustive buttons tancheng#54: fix issue and …
523bf44 
…correct typo
@yuqisun yuqisun linked a pull request Mar 6, 2025 that will close this issue
Reversed Heuristic and Exhaustive buttons #54: fix issue and correct typo #55
Merged
@yuqisun
Copy link
Collaborator

yuqisun commented Mar 6, 2025

Thanks @hiverniaa , you are right, just reproduced and push a fix PR.

Hi @tancheng ,
Raised PR to fix in code, will update image later. Could you help review?

Thanks,

tancheng added a commit that referenced this issue Mar 6, 2025
@tancheng
Merge pull request #55 from yuqisun/54-reversed-heuristic-and-exhaust…
ff5b3a3 
…ive-buttons

Reversed Heuristic and Exhaustive buttons #54: fix issue and correct typo
yuqisun added a commit to yuqisun/CGRA-Flow that referenced this issue Mar 7, 2025
@yuqisun
Reversed Heuristic and Exhaustive buttons tancheng#54: creating a bi-…
f02efc0 
…directional line with arrow head on each side
yuqisun added a commit to yuqisun/CGRA-Flow that referenced this issue Mar 8, 2025
@yuqisun
Update image version for issue tancheng#54
a72c5e0 
Reversed Heuristic and Exhaustive buttons tancheng#54
Update image accordingly.
@yuqisun yuqisun mentioned this issue Mar 8, 2025
Open
@yuqisun
Copy link
Collaborator

yuqisun commented Mar 8, 2025

Hi @hiverniaa , let you know new image pushed -> cgra/cgra-flow:20250308.

yuqisun added a commit to yuqisun/CGRA-Flow that referenced this issue Mar 8, 2025
@yuqisun
Reversed Heuristic and Exhaustive buttons tancheng#54: add vector lan…
4ec1560 
…es and data bitwidth and some minor adjustment
yuqisun added a commit to yuqisun/CGRA-Flow that referenced this issue Mar 10, 2025
@yuqisun
Reversed Heuristic and Exhaustive buttons tancheng#54: different text…
8bdaf40 
… color for multi-cgra frame
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqisun yuqisun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reversed Heuristic and Exhaustive buttons #54: fix issue and correct typo yuqisun/CGRA-Flow
2 participants
@yuqisun @hiverniaa