Implementation of call functions on iteration state #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Oct 24, 2020
Totktonada
reviewed
Oct 24, 2020
|
@zloidemon The changes you propose looks useful for me. I would rebase the PR on top of the current master, implement the changes I proposed above and split the commit into two ones: one re delays and another re callbacks. Aren't you mind? |
|
(Sorry for the looong delay.) |
Added the ability to set iteration and full scan delays for a task. iteration delay - max sleep time between iterations (in seconds). full scan delay - sleep time between full scans (in seconds). Related to tarantool#38
LeonidVas
force-pushed
the
on_iteration_func
branch
from
6ca84d7 to
15f8ea4
Compare
This was
linked to
issues
Nov 20, 2020
LeonidVas
force-pushed
the
on_iteration_func
branch
from
15f8ea4 to
29fced6
Compare
artemreyt
reviewed
Dec 2, 2020
| * `on_full_scan_success` - call function on success full scan iteration | ||
| Receives `(task)` as arguments. | ||
| * `on_full_scan_error` - call function on error full scan iteration | ||
| Receives `(task, error)` as arguments. |
There was a problem hiding this comment.
For me, it isn't obvious that on_full_scan_complete will be called after on_full_scan_success or on_full_scan_error. I propose to mention it.
Added callbacks for a task at various stages of the full scan iteration. `on_full_scan_start` - call function on starting full scan iteration. `on_full_scan_complete` - call function on complete full scan iteration. `on_full_scan_success` - call function on success full scan iteration. `on_full_scan_error` - call function on error full scan iteration. Closes tarantool#25
Added test delays (iteration and full scan) and full scan iteration callbacks.
LeonidVas
force-pushed
the
on_iteration_func
branch
from
29fced6 to
0c4d46d
Compare
Added. |
LeonidVas
requested review from
LeonidVas and
artemreyt
and removed request for
Totktonada and
LeonidVas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChangeLog: