Skip to content

Logger should not be mutated #28

@choubacha

Description

@choubacha

When we pass the logger to the client we end up changing the log level:

https://github.com/taskrabbit/waistband/blob/master/lib/waistband/index.rb#L279

The issue arises that this is a mutation on a logger instance that has not been defensively copied, therefore we're changing the logger for every instance.

This is likely not threadsafe.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions