Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make code cross platform using browser-compact.js #487

Closed
2 of 3 tasks
aatmanvaidya opened this issue Nov 21, 2023 · 1 comment
Closed
2 of 3 tasks

make code cross platform using browser-compact.js #487

aatmanvaidya opened this issue Nov 21, 2023 · 1 comment
Assignees
@aatmanvaidya
Labels
enhancement New feature or request level: ticket: bug tickets that are fixing bugs in existing codebase level:ticket An issue that describes a ticket (initiative>feature>ticket) plugin priority:high role:frontend size:1pt

Comments

@aatmanvaidya
Copy link
Collaborator

aatmanvaidya commented Nov 21, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

This issue is an extension to what is done here - #325 - @abhishek-nigam worked on issue 325 and made a PR for it - #401

we now have to make the code cross platform at the following places in the browser-extension

  • plugin/src/background.js - we also have to make the background.js file to accept imports
  • plugin/src/chrome.js
  • plugin/src/ui-components/pages/Preferences.jsx

Describe the solution you would like

We should use the code from browser-compact.js to make the code cross platform

Describe alternatives you've considered

No response

Addtional Context

No response
@aatmanvaidya aatmanvaidya added the enhancement New feature or request label Nov 21, 2023
@aatmanvaidya aatmanvaidya self-assigned this Nov 21, 2023
@aatmanvaidya aatmanvaidya added plugin level: ticket: bug tickets that are fixing bugs in existing codebase size:1pt priority:high role:frontend level:ticket An issue that describes a ticket (initiative>feature>ticket) labels Nov 21, 2023
@aatmanvaidya aatmanvaidya mentioned this issue Nov 21, 2023
Merged
@aatmanvaidya aatmanvaidya moved this to In Progress in 2023 Q4 Planner Nov 21, 2023
@aatmanvaidya
Copy link
Collaborator Author

The only task left in this issue is to make the background.js file accept imports.
@dennyabrain and I have tested out various methods, we need to play around and test more brute force ways to solve this

@aatmanvaidya aatmanvaidya added bug Something isn't working and removed bug Something isn't working labels Nov 30, 2023
@dennyabrain dennyabrain moved this from In Progress to Done in 2023 Q4 Planner Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aatmanvaidya aatmanvaidya

Labels
enhancement New feature or request level: ticket: bug tickets that are fixing bugs in existing codebase level:ticket An issue that describes a ticket (initiative>feature>ticket) plugin priority:high role:frontend size:1pt
Projects
No open projects
2023 Q4 Planner
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dennyabrain @aatmanvaidya