Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crash on executable check #9

Open
ieGod opened this issue Sep 2, 2021 · 0 comments
Open

crash on executable check #9

ieGod opened this issue Sep 2, 2021 · 0 comments

Comments

@ieGod
Copy link

ieGod commented Sep 2, 2021

  • MaccacreCompanion version: 7c5bda8
  • Python version: 2.9.5
  • Operating System: Win10

Description

Crashes on launch when trying to retrieve executable status.

readlog.py

check_process()
    status = subprocess.check_output(self.ed_process_name, shell=True).decode()

What I Did

C:\repos\EDMMC\edmmc>python edmmc.py
Active code page: 437
'EliteDangerous64.exe' is not recognized as an internal or external command,
operable program or batch file.
Exception in Tkinter callback
Traceback (most recent call last):
  File "C:\Users\b\AppData\Local\Programs\Python\Python39\lib\tkinter\__init__.py", line 1892, in __call__
    return self.func(*args)
  File "C:\Users\b\AppData\Local\Programs\Python\Python39\lib\tkinter\__init__.py", line 814, in callit
    func(*args)
  File "C:\repos\EDMMC\edmmc\edmmc.py", line 30, in update
    self.initialized = rl.initialize(rl.current_log, self.missions,
  File "C:\repos\EDMMC\edmmc\readlog.py", line 116, in initialize
    self.check_process()
  File "C:\repos\EDMMC\edmmc\readlog.py", line 106, in check_process
    status = subprocess.check_output(self.ed_process_name, shell=True).decode()
  File "C:\Users\b\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 424, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "C:\Users\b\AppData\Local\Programs\Python\Python39\lib\subprocess.py", line 528, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command 'EliteDangerous64.exe' returned non-zero exit status 1.

I basically just comment out the function and force the following:

        self.is_game_running = True
        self.label_texts.ed_status.set("ED client is running")

Of course, the application now doesn't actually check if ED is running but to be frank not my most desired feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant