Remove context None guard exception
#30
Open
+18
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrlpld
changed the title
None guard errorNone guard exception
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 254 252 -2
=========================================
- Hits 254 252 -2 ☔ View full report in Codecov by Sentry. |
tbrlpld
commented
Apr 4, 2024
| `None` was returned from `get_context_method`. | ||
|
|
||
| I was not able to find out why this check was put in place. The components usage | ||
| in Wagtail does not reveal any issues when the error is removed. Also, the |
There was a problem hiding this comment.
Suggested change
| in Wagtail does not reveal any issues when the error is removed. Also, the | |
| in Wagtail does not reveal any issues when the error guard is removed. | |
| Also, the |
tbrlpld
commented
Apr 4, 2024
|
|
||
| I was not able to find out why this check was put in place. The components usage | ||
| in Wagtail does not reveal any issues when the error is removed. Also, the | ||
| following template rendering works just fine with the context being `None`. |
There was a problem hiding this comment.
Suggested change
| following template rendering works just fine with the context being `None`. | |
| template rendering with `template.render(context)` works just fine with the context being `None`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist