-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Templex exploration #189
Closed
Closed
Templex exploration #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrlpld
force-pushed
the
templex-exploration
branch
from
October 11, 2023 00:46
59ee200
to
3d24799
Compare
It's just nicer to look at components when they don't touch the window border, which they never will in a real use.
This is better for reuse
This is so that a title without an image will not use the margin that is used to create the gap between the image and the text
The decorator now adds a method to the dataclass that handles the rendering logic. This is only done when no rendering method exists yet. This allows for completely custom rendering logic to be added. I find, this also reduces the logic and the complexity of the "templex" pattern, because we can work with fewer moving pieces.
This is just for testing things. I am currently no using it.
It does not really help... the dataclass decorator needs to be added to the specific class to make mypy understand the arguments. See also: https://mypy.readthedocs.io/en/stable/additional_features.html#caveats-known-issues
This is still not it.
This is for interoperability
tbrlpld
force-pushed
the
templex-exploration
branch
from
October 14, 2023 22:38
3d24799
to
cb15755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.