Add PlainMonthDay month code tests for non-ISO calendars #4709
+1,271
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessealama
force-pushed
the
plainmonthday-month-code-tests-v2
branch
4 times, most recently
from
8097c29 to
529ec83
Compare
ptomato
requested changes
Nov 26, 2025
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
Thanks for this. A few minor revisions and then it should be ready to go.
test/intl402/Temporal/PlainMonthDay/from/chinese-leap-month-codes-common.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainMonthDay/from/chinese-month-codes.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainMonthDay/from/chinese-month-codes.js
Outdated
Show resolved
Hide resolved
test/intl402/Temporal/PlainMonthDay/from/buddhist-month-codes.js
Outdated
Show resolved
Hide resolved
jessealama
force-pushed
the
plainmonthday-month-code-tests-v2
branch
from
7b0b748 to
6fb8185
Compare
19 tasks
Contributor
|
#4709 (comment) still needs to be applied, otherwise good to go |
Contributor
|
I can fix that up since it's the only thing blocking. |
ptomato
force-pushed
the
plainmonthday-month-code-tests-v2
branch
from
7e407a6 to
ec13dac
Compare
ptomato
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for
Temporal.PlainMonthDay.from()verifying that all valid month codes are accepted for various calendar systems.