Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk21 release #198

Closed
delanym opened this issue Sep 17, 2023 · 5 comments
Closed

jdk21 release #198

delanym opened this issue Sep 17, 2023 · 5 comments

Comments

@delanym
Copy link

delanym commented Sep 17, 2023

hi. Can we have another release for Java 21?

@tcurdt
Copy link
Owner

tcurdt commented Sep 18, 2023

Happy to release. But I guess this needs some testing first.
Have your tried or have run into problems?

The current CI only tests up to 19.

https://github.com/tcurdt/jdependency/blob/master/.github/workflows/ci.yml

I would also need to check if this needs an ASM upgrade.

@delanym
Copy link
Author

delanym commented Sep 18, 2023

I cloned and set my project shade-plugin to use the latest. No problems.

But I'm confused about something. Your pom already specifies asm 9.5 since 4 months ago
0923411

So what's with the 5 open pull requests making the same change?

@tcurdt
Copy link
Owner

tcurdt commented Sep 18, 2023

So what's with the 5 open pull requests making the same change?

That's a very good question. They don't make much sense and I also didn't notice them. It's a bit weird given the release in August. Anyway, I closed them and turned on java 21 for testing.

Unfortunately there is now support for java 21 on github yet.

https://github.com/tcurdt/jdependency/actions/runs/6220534843

Could not find satisfied version for semver 21.
Available versions: 20.0.2+9,

I have added java 20 to the testing matrix at least.

@tcurdt
Copy link
Owner

tcurdt commented Sep 18, 2023

Since 2.9.0 was already released in August with ASM 9.5.

https://github.com/tcurdt/jdependency/blob/jdependency-2.9.0/pom.xml

I am not sure what else needs to happen for java 21 at the moment.

@tcurdt
Copy link
Owner

tcurdt commented Sep 19, 2023

It seems like this is really a release request for the maven shade plugin and we can close this here?

@delanym delanym closed this as completed Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants