From 906e8f37423f8ae1193b9659ba38d616c688e378 Mon Sep 17 00:00:00 2001 From: slam Date: Sat, 24 Aug 2024 13:26:04 +0800 Subject: [PATCH] refactor - removeProvider update to use id --- .../kotlin/com/tddworks/openai/gateway/api/OpenAIGateway.kt | 2 +- .../openai/gateway/api/internal/DefaultOpenAIGateway.kt | 4 ++-- .../openai/gateway/api/internal/DefaultOpenAIGatewayTest.kt | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/OpenAIGateway.kt b/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/OpenAIGateway.kt index b6fec50..d62a142 100644 --- a/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/OpenAIGateway.kt +++ b/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/OpenAIGateway.kt @@ -16,6 +16,6 @@ interface OpenAIGateway : Chat, Completions { ) fun addProvider(provider: OpenAIProvider): OpenAIGateway - fun removeProvider(name: String) + fun removeProvider(id: String) fun getProviders(): List } \ No newline at end of file diff --git a/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGateway.kt b/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGateway.kt index 59001b3..0577c80 100644 --- a/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGateway.kt +++ b/openai-gateway/openai-gateway-core/src/commonMain/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGateway.kt @@ -77,8 +77,8 @@ class DefaultOpenAIGateway( return this } - override fun removeProvider(name: String) { - availableProviders.removeAll { it.name == name } + override fun removeProvider(id: String) { + availableProviders.removeAll { it.id == id } } override fun getProviders(): List { diff --git a/openai-gateway/openai-gateway-core/src/jvmTest/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGatewayTest.kt b/openai-gateway/openai-gateway-core/src/jvmTest/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGatewayTest.kt index 1bf2115..0a16682 100644 --- a/openai-gateway/openai-gateway-core/src/jvmTest/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGatewayTest.kt +++ b/openai-gateway/openai-gateway-core/src/jvmTest/kotlin/com/tddworks/openai/gateway/api/internal/DefaultOpenAIGatewayTest.kt @@ -150,7 +150,7 @@ class DefaultOpenAIGatewayTest { @Test fun `should able to remove provider`() { - openAIGateway.removeProvider(anthropic.name) + openAIGateway.removeProvider(anthropic.id) // Then assertEquals(3, openAIGateway.getProviders().size) assertEquals(azure, openAIGateway.getProviders().last())