From 85178dc9b977da30e6bceefc78cc9e9bbfa4f33e Mon Sep 17 00:00:00 2001
From: Haroen Viaene <hello@haroen.me>
Date: Wed, 6 Jul 2016 16:35:57 +0200
Subject: [PATCH] Use an a tag instead of data-href

fixes #398

This is necessary because it's useful to use regular clicking and allow for example opening in a new tab.

todo: test this properly (maybe it accidentally put a text-decoration)
---
 app/views/dataset/collection.blade.php | 8 ++++----
 app/views/ui/datasets/list.blade.php   | 6 +++---
 dev/js/script.js                       | 6 ------
 3 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/app/views/dataset/collection.blade.php b/app/views/dataset/collection.blade.php
index 73cd7ba3..05c12051 100644
--- a/app/views/dataset/collection.blade.php
+++ b/app/views/dataset/collection.blade.php
@@ -18,7 +18,7 @@
                 $collection_name = str_replace(URL::to('/'). '/', '', $collection);
             ?>
 
-            <div class="panel dataset dataset-link collection panel-default clickable-row" data-href='{{ URL::to($collection) }}'>
+            <a class="panel dataset dataset-link collection panel-default clickable-row" href='{{ URL::to($collection) }}'>
                 <div class="panel-body">
                     <div class='icon'>
                         <i class='fa fa-lg fa-folder-open-o'></i>
@@ -33,7 +33,7 @@
                         </div>
                     </div>
                 </div>
-            </div>
+            </a>
 
         @endforeach
 
@@ -42,7 +42,7 @@
                 $definition_name = str_replace(URL::to('/'). '/', '', $definition);
             ?>
 
-            <div class="panel dataset dataset-link panel-default clickable-row" data-href='{{ URL::to($definition) }}'>
+            <a class="panel dataset dataset-link panel-default clickable-row" href='{{ URL::to($definition) }}'>
                 <div class="panel-body">
                     <div class='icon'>
                         <i class='fa fa-lg fa-file-text-o'></i>
@@ -57,7 +57,7 @@
                         </div>
                     </div>
                 </div>
-            </div>
+            </a>
 
         @endforeach
 
diff --git a/app/views/ui/datasets/list.blade.php b/app/views/ui/datasets/list.blade.php
index 56f97958..d996771b 100644
--- a/app/views/ui/datasets/list.blade.php
+++ b/app/views/ui/datasets/list.blade.php
@@ -23,7 +23,7 @@
         <?php $i = 0; ?>
         @foreach($definitions as $definition)
 
-            <div class="panel dataset dataset-link button-row panel-default  @if(Tdt\Core\Auth\Auth::hasAccess('admin.dataset.update')) clickable-row @endif" data-href='{{ URL::to('api/admin/datasets/edit/' . $definition->id) }}'>
+            <a class="panel dataset dataset-link button-row panel-default  @if(Tdt\Core\Auth\Auth::hasAccess('admin.dataset.update')) clickable-row @endif" href='{{ URL::to('api/admin/datasets/edit/' . $definition->id) }}'>
                 <div class="panel-body"
                     @if($i==0)
                         data-step='3'
@@ -93,7 +93,7 @@
                         </div>
                     </div>
                 </div>
-            </div>
+            </a>
 
             <?php $i++; ?>
         @endforeach
@@ -126,4 +126,4 @@
             <i class='fa fa-search'></i>
         </div>
     @endif
-@stop
\ No newline at end of file
+@stop
diff --git a/dev/js/script.js b/dev/js/script.js
index e016a6ed..f6fd5aa4 100644
--- a/dev/js/script.js
+++ b/dev/js/script.js
@@ -1,12 +1,6 @@
 // Syntax highlighting
 prettyPrint();
 
-// Clickable rows
-$('.clickable-row').on('click', function(){
-    var url = $(this).data('href');
-    window.location = url;
-});
-
 // Filter datasets and collections
 $('#dataset-filter').on('keyup', function(){
     var filter = $(this).val();