Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not find config for page #47

Open
andycate opened this issue Feb 9, 2019 · 1 comment
Open

Could not find config for page #47

andycate opened this issue Feb 9, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@andycate
Copy link
Member

andycate commented Feb 9, 2019

When I request a page with a name that doesn't exist, I get this error:

org.team5499.dashboard.ConfigException: Could not get configuration for page with name drive
        at org.team5499.dashboard.Config.getPageAttributes(Config.kt:129)
        at org.team5499.dashboard.Dashboard$start$2.handle(Dashboard.kt:89)
        at org.team5499.dashboard.Dashboard$start$2.handle(Dashboard.kt:24)
        at spark.RouteImpl$1.handle(RouteImpl.java:72)
        at spark.http.matching.Routes.execute(Routes.java:61)
        at spark.http.matching.MatcherFilter.doFilter(MatcherFilter.java:134)
        at spark.embeddedserver.jetty.JettyHandler.doHandle(JettyHandler.java:50)
        at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1568)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:144)
        at org.eclipse.jetty.server.handler.HandlerList.handle(HandlerList.java:61)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132)
        at org.eclipse.jetty.server.Server.handle(Server.java:503)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:364)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:260)
        at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:305)
        at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:103)
        at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:118)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:765)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run(QueuedThreadPool.java:683)
        at java.base/java.lang.Thread.run(Thread.java:834)

To Reproduce:
Run the Playground server, and navigate to a page name that doesn't exist in the config file

@andycate andycate added the bug Something isn't working label Feb 9, 2019
@andycate
Copy link
Member Author

andycate commented Feb 9, 2019

We might consider a different way of handling this error, like a 404 response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant