From b2d3b20d6b8438e0368120620988d3221e8f834d Mon Sep 17 00:00:00 2001
From: Teccheck <mcteccy@protonmail.com>
Date: Mon, 15 May 2023 18:53:41 +0200
Subject: [PATCH] Code inspection

---
 app/build.gradle                                              | 4 ++--
 .../teccheck/fastlyrics/exceptions/LyricsApiException.kt      | 3 +--
 .../teccheck/fastlyrics/exceptions/LyricsNotFoundException.kt | 3 +--
 .../github/teccheck/fastlyrics/exceptions/NetworkException.kt | 3 +--
 .../teccheck/fastlyrics/exceptions/NoMusicPlayingException.kt | 3 +--
 .../github/teccheck/fastlyrics/exceptions/ParseException.kt   | 3 +--
 .../io/github/teccheck/fastlyrics/ui/saved/RecyclerAdapter.kt | 2 +-
 app/src/main/res/values-land/dimens.xml                       | 3 ---
 app/src/main/res/values-w1240dp/dimens.xml                    | 3 ---
 app/src/main/res/values-w600dp/dimens.xml                     | 3 ---
 app/src/main/res/values/colors.xml                            | 3 ---
 app/src/main/res/values/dimens.xml                            | 4 ----
 app/src/main/res/values/strings.xml                           | 4 ----
 build.gradle                                                  | 2 +-
 gradle.properties                                             | 2 +-
 settings.gradle                                               | 2 +-
 16 files changed, 11 insertions(+), 36 deletions(-)
 delete mode 100644 app/src/main/res/values-land/dimens.xml
 delete mode 100644 app/src/main/res/values-w1240dp/dimens.xml
 delete mode 100644 app/src/main/res/values-w600dp/dimens.xml

diff --git a/app/build.gradle b/app/build.gradle
index 9e21224..bed779e 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -38,7 +38,7 @@ android {
 }
 
 dependencies {
-    implementation 'androidx.core:core-ktx:1.10.0'
+    implementation 'androidx.core:core-ktx:1.10.1'
     implementation 'androidx.appcompat:appcompat:1.6.1'
     implementation 'androidx.constraintlayout:constraintlayout:2.1.4'
     implementation 'androidx.lifecycle:lifecycle-livedata-ktx:2.6.1'
@@ -48,7 +48,7 @@ dependencies {
     implementation 'androidx.swiperefreshlayout:swiperefreshlayout:1.1.0'
     implementation 'androidx.preference:preference-ktx:1.2.0'
 
-    implementation 'com.google.android.material:material:1.8.0'
+    implementation 'com.google.android.material:material:1.9.0'
     implementation 'com.google.code.gson:gson:2.10'
 
     implementation 'com.squareup.picasso:picasso:2.8'
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsApiException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsApiException.kt
index 3a08fbc..6ca276e 100644
--- a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsApiException.kt
+++ b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsApiException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-abstract class LyricsApiException {
-}
\ No newline at end of file
+abstract class LyricsApiException
\ No newline at end of file
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsNotFoundException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsNotFoundException.kt
index 67e666a..2d7e455 100644
--- a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsNotFoundException.kt
+++ b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/LyricsNotFoundException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class LyricsNotFoundException : LyricsApiException() {
-}
\ No newline at end of file
+class LyricsNotFoundException : LyricsApiException()
\ No newline at end of file
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NetworkException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NetworkException.kt
index 8fc20fa..3be7ad1 100644
--- a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NetworkException.kt
+++ b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NetworkException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class NetworkException : LyricsApiException() {
-}
\ No newline at end of file
+class NetworkException : LyricsApiException()
\ No newline at end of file
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NoMusicPlayingException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NoMusicPlayingException.kt
index 12e6b66..0197f2c 100644
--- a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NoMusicPlayingException.kt
+++ b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/NoMusicPlayingException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class NoMusicPlayingException : LyricsApiException() {
-}
\ No newline at end of file
+class NoMusicPlayingException : LyricsApiException()
\ No newline at end of file
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/ParseException.kt b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/ParseException.kt
index caa4fb4..87c2466 100644
--- a/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/ParseException.kt
+++ b/app/src/main/java/io/github/teccheck/fastlyrics/exceptions/ParseException.kt
@@ -1,4 +1,3 @@
 package io.github.teccheck.fastlyrics.exceptions
 
-class ParseException : LyricsApiException() {
-}
\ No newline at end of file
+class ParseException : LyricsApiException()
\ No newline at end of file
diff --git a/app/src/main/java/io/github/teccheck/fastlyrics/ui/saved/RecyclerAdapter.kt b/app/src/main/java/io/github/teccheck/fastlyrics/ui/saved/RecyclerAdapter.kt
index 5dee7e0..3a0e008 100644
--- a/app/src/main/java/io/github/teccheck/fastlyrics/ui/saved/RecyclerAdapter.kt
+++ b/app/src/main/java/io/github/teccheck/fastlyrics/ui/saved/RecyclerAdapter.kt
@@ -12,7 +12,7 @@ import com.squareup.picasso.Picasso
 import io.github.teccheck.fastlyrics.R
 import io.github.teccheck.fastlyrics.model.SongWithLyrics
 
-class RecyclerAdapter() :
+class RecyclerAdapter :
     RecyclerView.Adapter<RecyclerAdapter.ViewHolder>() {
 
     private var songs: List<SongWithLyrics> = listOf()
diff --git a/app/src/main/res/values-land/dimens.xml b/app/src/main/res/values-land/dimens.xml
deleted file mode 100644
index 22d7f00..0000000
--- a/app/src/main/res/values-land/dimens.xml
+++ /dev/null
@@ -1,3 +0,0 @@
-<resources>
-    <dimen name="fab_margin">48dp</dimen>
-</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values-w1240dp/dimens.xml b/app/src/main/res/values-w1240dp/dimens.xml
deleted file mode 100644
index d73f4a3..0000000
--- a/app/src/main/res/values-w1240dp/dimens.xml
+++ /dev/null
@@ -1,3 +0,0 @@
-<resources>
-    <dimen name="fab_margin">200dp</dimen>
-</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values-w600dp/dimens.xml b/app/src/main/res/values-w600dp/dimens.xml
deleted file mode 100644
index 22d7f00..0000000
--- a/app/src/main/res/values-w600dp/dimens.xml
+++ /dev/null
@@ -1,3 +0,0 @@
-<resources>
-    <dimen name="fab_margin">48dp</dimen>
-</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/colors.xml b/app/src/main/res/values/colors.xml
index df091cd..591c133 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -8,8 +8,5 @@
     <color name="theme_on_secondary">#ffffff</color>
 
     <color name="theme_background_dark">#202124</color>
-    <color name="nav_bar_color">#52000000</color>
 
-    <color name="black">#FF000000</color>
-    <color name="white">#FFFFFFFF</color>
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
index 4ab4520..b5d7896 100644
--- a/app/src/main/res/values/dimens.xml
+++ b/app/src/main/res/values/dimens.xml
@@ -1,8 +1,4 @@
 <resources>
     <!-- Default screen margins, per the Android Design guidelines. -->
     <dimen name="activity_horizontal_margin">16dp</dimen>
-    <dimen name="activity_vertical_margin">16dp</dimen>
-    <dimen name="nav_header_vertical_spacing">8dp</dimen>
-    <dimen name="nav_header_height">176dp</dimen>
-    <dimen name="fab_margin">16dp</dimen>
 </resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 112e634..9316d4c 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -2,10 +2,6 @@
     <string name="app_name">FastLyrics</string>
 
     <!-- Nav drawer -->
-    <string name="navigation_drawer_open">Open navigation drawer</string>
-    <string name="navigation_drawer_close">Close navigation drawer</string>
-    <string name="nav_header_desc">Navigation header</string>
-    <string name="nav_header_icon_desc">Navigation header icon</string>
 
     <string name="menu_lyrics">Lyrics</string>
     <string name="menu_saved">Saved</string>
diff --git a/build.gradle b/build.gradle
index 2f6ad9b..ac585df 100644
--- a/build.gradle
+++ b/build.gradle
@@ -5,7 +5,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:8.0.0'
+        classpath 'com.android.tools.build:gradle:8.0.1'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.0'
 
         // NOTE: Do not place your application dependencies here; they belong
diff --git a/gradle.properties b/gradle.properties
index 8145fa7..463695e 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -20,5 +20,5 @@ android.enableJetifier=true
 # Kotlin code style for this project: "official" or "obsolete":
 kotlin.code.style=official
 android.defaults.buildfeatures.buildconfig=true
-android.nonTransitiveRClass=false
+android.nonTransitiveRClass=true
 android.nonFinalResIds=false
\ No newline at end of file
diff --git a/settings.gradle b/settings.gradle
index f080ab4..02f1f61 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -3,7 +3,7 @@ dependencyResolutionManagement {
     repositories {
         google()
         mavenCentral()
-        jcenter() // Warning: this repository is going to shut down soon
+         // Warning: this repository is going to shut down soon
     }
 }
 rootProject.name = "FastLyrics"