Merge pull request #33 from techniq/themestore-system-dark-mode

techniq · web-flow · commit 11218f232e85 · 2025-03-06T13:48:19.000-05:00
fix(themeStore): Only manage system dark mode (`&lt;html class="dark"&gt;`) if there are any dark themes defined
diff --git a/.changeset/fresh-worlds-retire.md b/.changeset/fresh-worlds-retire.md
@@ -0,0 +1,5 @@
+---
+'@layerstack/svelte-stores': patch
+---
+
+fix(themeStore): Only manage system dark mode (`<html class="dark">`) if there are any dark themes defined
diff --git a/packages/svelte-stores/src/lib/themeStore.ts b/packages/svelte-stores/src/lib/themeStore.ts
@@ -48,10 +48,13 @@ export function createThemeStore(options: ThemeStoreOptions): ThemeStore {
   let darkMatcher = window.matchMedia('(prefers-color-scheme: dark)');
 
   function resolveSystemTheme({ matches }: { matches: boolean }) {
-    if (matches && options.dark.length) {
-      document.documentElement.classList.add('dark');
-    } else {
-      document.documentElement.classList.remove('dark');
+    // Only manage dark mode (`<html class="dark">`) if there are any dark themes defined
+    if (options.dark.length) {
+      if (matches) {
+        document.documentElement.classList.add('dark');
+      } else {
+        document.documentElement.classList.remove('dark');
+      }
     }
 
     store.set(new CurrentTheme(null, matches));

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@layerstack/svelte-stores': patch
 +---
++
 +fix(themeStore): Only manage system dark mode (`<html class="dark">`) if there are any dark themes defined