Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDFSection - allow PDFSectionColumns to have equal heights #271

Open
grantespo opened this issue Apr 13, 2021 · 1 comment
Open

PDFSection - allow PDFSectionColumns to have equal heights #271

grantespo opened this issue Apr 13, 2021 · 1 comment

Comments

@grantespo
Copy link

grantespo commented Apr 13, 2021

I have a PDFSection with 3 columns. Each PDFSectionColumn contains a PDFTable where the height is dynamic.

Problem: columns have different heights (based on their respective content)

Solution: ability to set config to force each column to have equal height:
e.g.: pdfSection.equalColumnHeights = true

Maybe there is a simpler alternative that I'm missing.
Hard to know what to do since a lot of the docs are missing description, majority of classes just says TODO

overall, amazing library though. Thanks!

@grantespo grantespo changed the title PDFSection - allow PDFSectionColumns to columns to have equal heights PDFSection - allow PDFSectionColumns to have equal heights Apr 13, 2021
@philprime
Copy link
Member

philprime commented Apr 14, 2021

Hi @grantespo, thanks for opening up the issue.

About the docs: Yes, you are right, they definitely lack on completeness, due to me working mostly alone on it (except for the amazing contributors)

Is the usage documentation any help?

I like your solution with the equalColumnHeights but it isn't this easy (is it ever? 😄)
How would the content of each section be affected?
When using tables we can increase the padding around cell content and cell borders, but how about all the other data types? Should an image be stretched, etc.?

From a quick look at the problem space, I believe this won't be trivial to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants