Support inheritance when parent is a list and child is not a list #228

bgoncalv · 2024-04-11T12:48:51Z

Looking at https://tmt.readthedocs.io/en/stable/guide.html#inherit-plans

discover:
    how: fmf
    url: https://github.com/teemtee/tmt
prepare:
    how: ansible
    playbook: ansible/packages.yml
execute:
    how: tmt

/basic:
    summary: Quick set of basic functionality tests
    discover+:
        filter: tier:1

/features:
    summary: Detailed tests for individual features
    discover+:
        filter: tier:2

there are 2 plans that extend the discover with filter option. This works well, as discover is a dict.

discover can also be a list, but in that case the inheritance doesn't work.

discover:
    - how: fmf
      url: https://github.com/project1
    - how: fmf
      url: https://github.com/project2

/basic:
    summary: Quick set of basic functionality tests
    discover+:
        filter: tier:1

/features:
    summary: Detailed tests for individual features
    discover+:
        filter: tier:2

It causes error: MergeError: Key 'discover' in /basic (can only concatenate list (not "dict") to list).

My assumption would be that each entry in the list would be updated with provided dictionary.

The text was updated successfully, but these errors were encountered:

psss · 2024-04-11T13:00:19Z

Supporting this use case sounds like a reasonable extension of the current implementation. Might be a little bit confusing to users but, I guess, if it is well documented, should be ok.

To sum up the proposed approach when parent is a list:

child is a list ... those would be just concatenated
child is a dict ... [parent_item.update(child_value) for parent_item in parent] would be done
child is anything else ... [parent_item + child_value for parent_item in parent] would be performed

Any concerns about this approach? I guess, similar should be done for the - operator as well.

lukaszachy · 2024-04-11T13:05:35Z

+1 for this, should be very useful

LecrisUT · 2024-04-11T13:05:43Z

I think this should be better handled in tmt and have fmf be more specific. One way would be to expose a plugin for the +/- operators that the specific user of the fmf tree can expand. Currently this can be circumvented by making the discover+: be a list.

lukaszachy · 2024-04-11T13:17:53Z

@LecrisUT Is that a necessary complication?

What you mean by "Currently this can be circumvented by making the discover+: be a list."?
There is no way how to add / change attribute of discover phase, is it?

e.g. have two phases and add new attribute to each of them

LecrisUT · 2024-04-11T13:23:58Z

What you mean by "Currently this can be circumvented by making the discover+: be a list."?
There is no way how to add / change attribute of discover phase, is it?

The following should work (note the extra -). I use something similar for tag

discover:
  - how: fmf
    url: https://github.com/project1
  - how: fmf
    url: https://github.com/project2

/basic:
  summary: Quick set of basic functionality tests
  discover+:
    - filter: tier:1

$ fmf show
/test/basic
discover: [{'how': 'fmf', 'url': 'https://github.com/project1'},
 {'how': 'fmf', 'url': 'https://github.com/project2'},
 {'filter': 'tier:1'}]
summary: Quick set of basic functionality tests

@LecrisUT Is that a necessary complication?

Yes, I want to use fmf in more general context outside of tmt. E.g. I am using it with fmf-jinja for generating input files for HPC academic software. I do want to see fmf progress more so I can push this as a stable and feasible workflow for that community.

This change is currently very tmt specific and would break the generality.

bgoncalv · 2024-04-11T13:30:43Z

What you mean by "Currently this can be circumvented by making the discover+: be a list."?
There is no way how to add / change attribute of discover phase, is it?

The following should work (note the extra -). I use something similar for tag
discover:
  - how: fmf
    url: https://github.com/project1
  - how: fmf
    url: https://github.com/project2

/basic:
  summary: Quick set of basic functionality tests
  discover+:
    - filter: tier:1

this doesn't work. It doesn't update the current entries, but add a new entry to the list {how: shell, filter: 'tier:1'}

LecrisUT · 2024-04-11T13:38:12Z

Aah, I misunderstood the situation. You mean the + would add the value to all of the items in the list. It feels very error prone, e.g. when you change the type of tag for example from a value to a list it would have surprising consequences.

What about using a more yaml-like syntax like discover<: (derived from <<: *)

bgoncalv · 2024-04-11T13:47:00Z

What about using a more yaml-like syntax like discover<: (derived from <<: *)

I personally don't have any syntax preference it is just currently afaik there is no way I can add/update items when it is in a list.

lukaszachy · 2024-04-11T16:19:53Z

Aah, I misunderstood the situation. You mean the + would add the value to all of the items in the list. It feels very error prone, e.g. when you change the type of tag for example from a value to a list it would have surprising consequences.

Whole merging stuff is very error prone already. If time allows there is a plan to provide command to 'explain what is being done with data...' which could put some light into it if one is in bind.

Currently we have traceback when merging list with dict (or any other type) - Thus any change in this sense will not break an existing valid fmf files. The list with list merging is not going to change - for this reason I think it can be done in fmf directly without any callback/plugins currently.

But having way to customize merge_special might be handy for others, that is for sure. Could you file an RFE for that?

psss · 2024-04-22T15:13:16Z

I'm here with @lukaszachy. The current behavior is not changed, only the invalid combinations (e.g. list+non-list which are now tracebacking) would be interpreted in a different way. So this would be just extending the current implementation. On the other hand, catching exceptions for unsupported operations can be also a valid use case (not for tmt but there could be other applications for the concept).

So, perhaps, a dedicated operator for this could be a little bit better, to make it obvious at the first sight that something different than just a regular addition is happening? Sounds more in the direction of explicit it better than implicit. And I bet that @happz would vote for this approach as well? Or am I wrong?

happz · 2024-04-25T08:03:11Z

I'm here with @lukaszachy. The current behavior is not changed, only the invalid combinations (e.g. list+non-list which are now tracebacking) would be interpreted in a different way. So this would be just extending the current implementation. On the other hand, catching exceptions for unsupported operations can be also a valid use case (not for tmt but there could be other applications for the concept).

So, perhaps, a dedicated operator for this could be a little bit better, to make it obvious at the first sight that something different than just a regular addition is happening? Sounds more in the direction of explicit it better than implicit. And I bet that @happz would vote for this approach as well? Or am I wrong?

Actually, I would be fine with using the same operator, in this case :) I might be getting it wrong, but IIUIC, the goal is to enable the list + not a list operation, by adding the not a list as an item to the existing list, correct? If that's so, + (and - too) would work for my taste. I can imagine a warning, for example, "merged list and not a list, just so you're aware", but having an operator for "addition" and an operator for "addition but when operands are not compatible" feels like too many details being thrown users' direction.

It seems similar to + in Python: there's still one operator that raises an error if operands are not compatible, and the solution to such an issue is to coerce one of the operands instead of having a new operator. In our case, the coercion would be implicit, but I'd get a warning. Or not, might be considered as fine enough to go silently if documented and defined as something that fmf does intentionally and not by accident. I would be fine with that too.

psss · 2024-05-13T13:13:27Z

I might be getting it wrong, but IIUIC, the goal is to enable the list + not a list operation, by adding the not a list as an item to the existing list, correct?

@happz, actually, the proposed implementation is different, see the comment above for details. Basically it aims to cover the use case provided by @bgoncalv, for example adding the same filter field into multiple discover step phases. So there's a bit more magic then just appending a non-list item to a list.

The-Mule · 2024-06-07T10:45:14Z

I would also appreciate having this implemented, it is very useful for plans that are more or less the same but only differ slightly by the test selection (we have a very clear and specific use case for CI). I just want to double check that I understand it correctly. Assume I have the following plans:

discover:
  - how: fmf
    url: https://github.com/project1
  - how: fmf
    url: https://github.com/project2
    filter: tier:1
  - how: fmf
    url: https://github.com/project3
    tests:
      - first      # this one has tier: 1
      - second     # this one has tier: 2
      - third      # this one has tier: 3

/A:
  discover+:
    - filter: tier:1

/B:
  discover+:
    - filter: tier:2

/C:
  discover+:
     - tests:
        - third

Do I understand correctly that selection in plans A, B, C is applied on all tests found by the main discover? IOW

A contains tier 1 tests from project1 and project2 and 'first' tests from project3
B contains tier 2 tests from project1, nothing from project2 and 'second' from project3
C contains only 'third' test from project3 and nothing else (under assumption that there is no test of that name in project1 and project2)

Is all this compatible with the original request and proposed approach?

The-Mule · 2024-06-07T10:51:51Z

The reason why this could be pretty useful is that in general you have expect many items in discover phase (mutliple test sources, some of them using filters, some of them using explicit test selection, etc.) and you might easily end up with a discover phase that have ~100 lines of code.

Now you want to run the plan in different configurations, e.g. you need to run the same plan with and without buildroot - obviously you want to add another filter for that but other than that the discover is pretty much the same regardless of buildroot. Add testing in FIPS and from 2 plans you have 4 - again, the only difference between discover phases in all 4 plans is that you want to use a different test selection. With 4 plans we are already talking about significant duplication of discover phases (unless this RFE is implemented).

LecrisUT · 2024-06-07T11:14:44Z

If you have a list like:

/B:
  discover+:
    - filter: tier:2

Then the current implementation applies and you get:

/B:
  discover:
    - how: fmf
      url: https://github.com/project1
    - how: fmf
      url: https://github.com/project2
      filter: tier:1
    - how: fmf
      url: https://github.com/project3
      tests:
        - first      # this one has tier: 1
        - second     # this one has tier: 2
        - third      # this one has tier: 3
    - filter: tier:2

The proposal here kicks in when you make the value a dict (or string)

/B:
  discover+:
    filter: tier:2

Then it would be like the + operator is applied to each individual item there:

/B:
  discover:
    - how: fmf
      url: https://github.com/project1
      filter: tier:2
    - how: fmf
      url: https://github.com/project2
      filter: tier:2
    - how: fmf
      url: https://github.com/project3
      tests:
        - first      # this one has tier: 1
        - second     # this one has tier: 2
        - third      # this one has tier: 3
      filter: tier:2

The-Mule · 2024-06-07T11:42:50Z

Yes, so it is basically what I want.

I assume that it is already (in the current 'inheritance' implementation) handled that if you have, for instance, a filter already present in the main discover phase and you are adding one more in discover+ they are merged into the list (ie. final result is a conjunction of both) and this applies not just to filter but e.g. to tests too (except that the result is an intersection).

LecrisUT · 2024-06-07T11:50:33Z

There is no special treatment for filter, tests, etc. All are just yaml fields. There is just some magic on top of it for handling operators, path, inheritance, etc. to make yaml -> fmf.

So you can still add filter+:, tests-: to alter the behavior more granularly. It's the subsequent operator (or lack of) that determines how the fields are treated. Well having the - operator would be a bit more tricky depending on if it should fail if the parent has the item or not, but with the new -~ operator should be able to distinguish between the the 2 cases.

psss · 2024-06-10T13:06:47Z

I assume that it is already (in the current 'inheritance' implementation) handled that if you have, for instance, a filter already present in the main discover phase and you are adding one more in discover+ they are merged into the list

Just to clarify the filter extension versus overriding the parent value: For the following plan:

discover:
    how: fmf
    filter:
      - tier:1

/extend:
    discover+:
        filter+:
          - tier:2

/override:
    discover+:
        filter:
          - tier:2

You would get this in the data:

> fmf show
/plans/example/extend
discover: {'filter': ['tier:1', 'tier:2'], 'how': 'fmf'}

/plans/example/override
discover: {'filter': ['tier:2'], 'how': 'fmf'}

For the multiple-phase-update case proposed here it should behave similarly. Just note, that the plan is to use a dedicated operator in order to prevent confusion with the normal merging using the +.

Btw, any idea about a suitable character to be used for this? Trying some brainstorm:

applying addition to multiple items of a list sounds a bit like multiplication, so parent*?
it is supposed to be an extended version of the + operation, so ++ like applying additiona several times?
use another modifier after the + character? something like +~, +|, +*

Any better ideas?

LecrisUT · 2024-06-10T13:46:38Z

Btw, any idea about a suitable character to be used for this? Trying some brainstorm:

Might create more confusion due to lack of support for other operators, but how about field[]+:? Reasoning is that this operator is specific to lists only.

KwisatzHaderach · 2024-10-30T16:44:11Z

We have a similar need to teemtee/tmt#3198 we need the inverse of this, we have common arguments for discover we want each discover list item to inherit

main.fmf

discover:
    how: fmf
    prune: True
    adjust-tests:
        - duration+: '*3'
          when: hw == slow

plan.fmf

discover+:
    - name: upstream
      url: https://some.url
    - name: downstream
      url: https://other.url

I guess the solution will be same/similar for both versions of this issue, so not creating another one.

ep69 · 2024-11-06T14:04:04Z

Btw, any idea about a suitable character to be used for this? Trying some brainstorm:

* applying `addition` to multiple items of a list sounds a bit like multiplication, so `parent*`?

* it is supposed to be an extended version of the `+` operation, so `++` like applying additiona several times?

* use another modifier after the `+` character? something like `+~`, `+|`, `+*`

Any better ideas?

If it is about applying same operation to all items of the list, map comes to mind. Is something like |map realistic, considering technical constraints? 🤔

kkaarreell · 2024-11-07T08:25:02Z

Reading the example mentioned above

discover:
    - how: fmf
      url: https://github.com/project1
    - how: fmf
      url: https://github.com/project2

/basic:
    summary: Quick set of basic functionality tests
    discover+:
        filter: tier:1

/features:
    summary: Detailed tests for individual features
    discover+:
        filter: tier:2

Do we even need a special syntax? Isn't it implied due to a fact that the target of adjust is a list and "params" of adjust is not a list but a dict?

LecrisUT · 2024-11-07T09:01:10Z

The idea is to prevent accidental operations. Let's say that the operation is done on a fmf file that is in another repo which didn't had discover as a list, then it can continue to apply even if the tests should be checked more carefully. The consequences on discover are not that prominent, but consider it applied to prepare, that could be more tricky to pick up on.

kkaarreell · 2024-11-07T10:18:16Z

LecrisUT

Is it possible to process files across repos? Anyway, I agree that being explicite Is better, I like * symbol

kkaarreell · 2024-11-07T11:35:54Z

I did POC of +* operator in #256
If you are OK with the approach&code I can extend it co include -* as well.

psss transferred this issue from teemtee/tmt Apr 11, 2024

psss added the inheritance label Apr 11, 2024

psss changed the title ~~RFE: plans inheritance - add inheritance support when entry is a list~~ Add inheritance support when parent is a list and child is not a list Apr 11, 2024

psss changed the title ~~Add inheritance support when parent is a list and child is not a list~~ Support inheritance when parent is a list and child is not a list Apr 11, 2024

psss added this to the 1.4 milestone Apr 11, 2024

lukaszachy modified the milestones: 1.4, 1.5 May 28, 2024

LecrisUT mentioned this issue Jun 26, 2024

Make the result of an empty plan configurable teemtee/tmt#3042

Open

LecrisUT mentioned this issue Sep 21, 2024

MergeError if tag as list inherits tag as a string from the upper node teemtee/tmt#3198

Open

martinhoyer modified the milestone: 1.5 Nov 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support inheritance when parent is a list and child is not a list #228

Support inheritance when parent is a list and child is not a list #228

bgoncalv commented Apr 11, 2024

psss commented Apr 11, 2024

lukaszachy commented Apr 11, 2024

LecrisUT commented Apr 11, 2024 •

edited

Loading

lukaszachy commented Apr 11, 2024

LecrisUT commented Apr 11, 2024 •

edited

Loading

bgoncalv commented Apr 11, 2024

LecrisUT commented Apr 11, 2024

bgoncalv commented Apr 11, 2024

lukaszachy commented Apr 11, 2024

psss commented Apr 22, 2024

happz commented Apr 25, 2024

psss commented May 13, 2024

The-Mule commented Jun 7, 2024

The-Mule commented Jun 7, 2024

LecrisUT commented Jun 7, 2024 •

edited

Loading

The-Mule commented Jun 7, 2024

LecrisUT commented Jun 7, 2024 •

edited

Loading

psss commented Jun 10, 2024

LecrisUT commented Jun 10, 2024

KwisatzHaderach commented Oct 30, 2024 •

edited

Loading

ep69 commented Nov 6, 2024

kkaarreell commented Nov 7, 2024

LecrisUT commented Nov 7, 2024

kkaarreell commented Nov 7, 2024

kkaarreell commented Nov 7, 2024

Support inheritance when parent is a list and child is not a list #228

Support inheritance when parent is a list and child is not a list #228

Comments

bgoncalv commented Apr 11, 2024

psss commented Apr 11, 2024

lukaszachy commented Apr 11, 2024

LecrisUT commented Apr 11, 2024 • edited Loading

lukaszachy commented Apr 11, 2024

LecrisUT commented Apr 11, 2024 • edited Loading

bgoncalv commented Apr 11, 2024

LecrisUT commented Apr 11, 2024

bgoncalv commented Apr 11, 2024

lukaszachy commented Apr 11, 2024

psss commented Apr 22, 2024

happz commented Apr 25, 2024

psss commented May 13, 2024

The-Mule commented Jun 7, 2024

The-Mule commented Jun 7, 2024

LecrisUT commented Jun 7, 2024 • edited Loading

The-Mule commented Jun 7, 2024

LecrisUT commented Jun 7, 2024 • edited Loading

psss commented Jun 10, 2024

LecrisUT commented Jun 10, 2024

KwisatzHaderach commented Oct 30, 2024 • edited Loading

ep69 commented Nov 6, 2024

kkaarreell commented Nov 7, 2024

LecrisUT commented Nov 7, 2024

kkaarreell commented Nov 7, 2024

kkaarreell commented Nov 7, 2024

LecrisUT commented Apr 11, 2024 •

edited

Loading

LecrisUT commented Apr 11, 2024 •

edited

Loading

LecrisUT commented Jun 7, 2024 •

edited

Loading

LecrisUT commented Jun 7, 2024 •

edited

Loading

KwisatzHaderach commented Oct 30, 2024 •

edited

Loading