Skip to content

Commit 7f1263a

Browse files
committed
Wait on final state instead intermediate
This will change the kubectl wait command to wait till phase is succeeded instead of running as running is intermediate state and if changes to succeeded fast, it ends up in timeout
1 parent d3b8050 commit 7f1263a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/e2e/eventlistener/eventListener_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ func TestEventListenerLogsE2E(t *testing.T) {
7373
createResources(t, c, namespace)
7474
kubectl.MustSucceed(t, "create", "-f", helper.GetResourcePath("eventlistener/eventlistener_log.yaml"))
7575
// Wait for pods to run and crash for next test
76-
kubectl.MustSucceed(t, "wait", "--for=jsonpath=.status.phase=Running", "pod", "-n", namespace, "--timeout=2m", "--all")
76+
kubectl.MustSucceed(t, "wait", "--for=jsonpath=.status.phase=Succeeded", "pod", "-n", namespace, "--timeout=2m", "--all")
7777

7878
t.Run("Get logs of EventListener", func(t *testing.T) {
7979
res := tkn.MustSucceed(t, "eventlistener", "logs", elName, "-t", "1")
@@ -108,7 +108,7 @@ func TestEventListener_v1beta1LogsE2E(t *testing.T) {
108108
createResources(t, c, namespace)
109109
kubectl.MustSucceed(t, "create", "-f", helper.GetResourcePath("eventlistener/eventlistener_v1beta1_log.yaml"))
110110
// Wait for pods to run and crash for next test
111-
kubectl.MustSucceed(t, "wait", "--for=jsonpath=.status.phase=Running", "pod", "-n", namespace, "--timeout=2m", "--all")
111+
kubectl.MustSucceed(t, "wait", "--for=jsonpath=.status.phase=Succeeded", "pod", "-n", namespace, "--timeout=2m", "--all")
112112

113113
t.Run("Get logs of EventListener", func(t *testing.T) {
114114
res := tkn.MustSucceed(t, "eventlistener", "logs", elName, "-t", "1")

0 commit comments

Comments
 (0)