-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Open
Labels
area/plumbingIssues or PRs related to the plumbing infrastructure but needing attention in a non-plumbing repo.Issues or PRs related to the plumbing infrastructure but needing attention in a non-plumbing repo.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Description
Problem
zizmor reports secrets-inherit in chatops_retest.yaml. The workflow uses secrets: inherit which passes all parent secrets to the reusable workflow tektoncd/plumbing/.github/workflows/_chatops_retest.yml, when it only needs CHATOPS_TOKEN.
Current
# .github/workflows/chatops_retest.yaml
jobs:
retest:
uses: tektoncd/plumbing/.github/workflows/_chatops_retest.yml@48c53b4e... # main
secrets: inheritProposed fix
jobs:
retest:
uses: tektoncd/plumbing/.github/workflows/_chatops_retest.yml@48c53b4e... # main
secrets:
CHATOPS_TOKEN: ${{ secrets.CHATOPS_TOKEN }}Note: This also requires a change in tektoncd/plumbing to declare secrets: inputs in _chatops_retest.yml:
on:
workflow_call:
secrets:
CHATOPS_TOKEN:
required: trueContext
Identified by zizmor v1.23.1. Related to #9667.
/kind cleanup
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area/plumbingIssues or PRs related to the plumbing infrastructure but needing attention in a non-plumbing repo.Issues or PRs related to the plumbing infrastructure but needing attention in a non-plumbing repo.kind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.Categorizes issue or PR as related to cleaning up code, process, or technical debt.