Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ehncance /accounts current PR #932

Open
Viterbo opened this issue Jan 13, 2025 · 0 comments · Fixed by #943
Open

Ehncance /accounts current PR #932

Viterbo opened this issue Jan 13, 2025 · 0 comments · Fixed by #943
Assignees

Comments

@Viterbo
Copy link
Collaborator

Viterbo commented Jan 13, 2025

Description

The current implementation of the /accounts page needs to be improved to show more information like: rank position, transactions count and percentage. This will enhance usability and align with user expectations.

Fixed here: #943

Tasks

  1. Add Pagination at the Top

    • Implement pagination controls at the top of the table.
    • Ensure these controls work seamlessly with the existing bottom pagination controls.
    • Do not include a "quantity selector" (number of items per page) in the top pagination.
  2. URL Updates for Pagination

    • Ensure pagination updates are reflected in the URL query parameters.
      • Example: /accounts?p=2&ps=50 for page 2 with 50 items per page.
    • Clicking on pagination controls should update the URL accordingly.
    • Allow users to share or bookmark a specific page by URL.
  3. Add Rank Column

    • Introduce a new "Rank" column as the first column in the table.
    • Display the rank of each account (e.g., 1, 2, 3...).
    • Ensure sorting consistency with the rest of the table.
  4. [CANCELED] Add Transaction Count Column

    • Add a new column for the "Transaction Count" as the last column in the table.
    • Display the total number of transactions associated with each account.
    • Ensure sorting functionality is available for this column.
      Note: this requirement is not longer part of this issue and has been moved to its own issue here: Add transaction count column on /accounts section #934

Additional Notes

  • The column order should be:
    1. Rank
    2. Address
    3. Balance
    4. Percentage
    5. [CANCELED] Transaction Count - this column should be added later (tracked on this issue)
  • Maintain consistency with the Quasar and Vue.js setup used across the project.
  • Refer to the current implementation of /accounts and Etherscan for reference.

Acceptance Criteria

  • All the above tasks are implemented and functional.
  • Pagination updates are reflected in the URL and maintain state upon refresh.
  • Columns are added and sorted correctly.
  • No visual or functional regressions in the /accounts page.

Required PR: Enhance /v1/balances endpoint results
Original PR: #931
Checkout from Branch: 927-add-holders-for-tlos-itself-create-accounts-endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant