-
Notifications
You must be signed in to change notification settings - Fork 48
Update tembo-operator for new base image #1187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theory
added a commit
that referenced
this pull request
Mar 13, 2025
These images include Trunk v0.16.1, which as of #1187 the operator will require.
theory
added a commit
that referenced
this pull request
Mar 13, 2025
theory
added a commit
that referenced
this pull request
Mar 13, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Update `execute_extension_install_command()` to tell `trunk` to install extension modules into `module_dir`. Requires Trunk v0.16.1. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Update non-test values to reference the new image as defaults. Even though we're not fully ready to adopt the new image, this change shouldn't impact things because the stack configurations all define images. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
7ce5382
to
7a7cef1
Compare
nhudson
approved these changes
Mar 13, 2025
theory
added a commit
that referenced
this pull request
Mar 13, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Update `execute_extension_install_command()` to tell `trunk` to install extension modules into `module_dir`. Requires Trunk v0.16.1. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Update non-test values to reference the new image as defaults. Even though we're not fully ready to adopt the new image, this change shouldn't impact things because the stack configurations all define images. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
7a7cef1
to
8039877
Compare
theory
added a commit
that referenced
this pull request
Mar 14, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Update `execute_extension_install_command()` to tell `trunk` to install extension modules into `module_dir`. Requires Trunk v0.16.1. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Update non-test values to reference the new image as defaults. Even though we're not fully ready to adopt the new image, this change shouldn't impact things because the stack configurations all define images. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
8039877
to
23af159
Compare
theory
added a commit
that referenced
this pull request
Mar 14, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Update `execute_extension_install_command()` to tell `trunk` to install extension modules into `module_dir`. Requires Trunk v0.16.1. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
28c87af
to
a761cb0
Compare
theory
added a commit
that referenced
this pull request
Mar 17, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
a761cb0
to
b8251f5
Compare
theory
added a commit
that referenced
this pull request
Mar 17, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
b8251f5
to
7c205a4
Compare
theory
added a commit
that referenced
this pull request
Mar 17, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
7c205a4
to
035ff6a
Compare
theory
added a commit
that referenced
this pull request
Mar 17, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements` and to include the new module directory in `dynamic_library_path`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
035ff6a
to
ef5e6b9
Compare
theory
added a commit
that referenced
this pull request
Mar 17, 2025
The new tembo/postgres image stores files in new locations on the persistent volume, so teach `CoreDBSpec` to recognize the new image and add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to return the proper locations. Update `check_for_so_files()` to use these methods rather than a hard-coded directory, and also to include the `.so` file name in the `ls` command to reduce I/O. Remove the old `postgres_major_version_from_cdb` function, as the `pg_major` method takes its place (and returns a default rather than an error when it can't parse the image name for some reason). Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations. Also update `tembo-operator/yaml/sample-standard.yaml` to require the latest `pg_stat_statements`. Also: the `RolePassword.password` field is never read, so change is name to `_password` to eliminate warnings.
ef5e6b9
to
2befbb0
Compare
Was merged in 2befbb0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tembo/postgres image stores files in new locations on the persistent volume, so teach
CoreDBSpec
to recognize the new image and add the methodspg_major
,share_dir
,module_dir
, andlib_dir
to return the proper locations. Updatecheck_for_so_files()
to use these methods rather than a hard-coded directory, and also to include the.so
file name in thels
command to reduce I/O.Remove the old
postgres_major_version_from_cdb
function, as thepg_major
method takes its place (and returns a default rather than an error when it can't parse the image name for some reason).Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations.
Also update
tembo-operator/yaml/sample-standard.yaml
to require the latestpg_stat_statements
.Also: the
RolePassword.password
field is never read, so change is name to_password
to eliminate warnings.