Skip to content

Update tembo-operator for new base image #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

theory
Copy link
Contributor

@theory theory commented Mar 13, 2025

The new tembo/postgres image stores files in new locations on the persistent volume, so teach CoreDBSpec to recognize the new image and add the methods pg_major, share_dir, module_dir, and lib_dir to return the proper locations. Update check_for_so_files() to use these methods rather than a hard-coded directory, and also to include the .so file name in the ls command to reduce I/O.

Remove the old postgres_major_version_from_cdb function, as the pg_major method takes its place (and returns a default rather than an error when it can't parse the image name for some reason).

Leave various defaults and tests using the existing images, as more updates will be needed before we can run the new image, but sync them up to use the latest image SHA1, the same on found in stack configurations.

Also update tembo-operator/yaml/sample-standard.yaml to require the latest pg_stat_statements.

Also: the RolePassword.password field is never read, so change is name to _password to eliminate warnings.

@theory theory self-assigned this Mar 13, 2025
theory added a commit that referenced this pull request Mar 13, 2025
These images include Trunk v0.16.1, which as of #1187 the operator will
require.
theory added a commit that referenced this pull request Mar 13, 2025
These images include Trunk v0.16.1, which as of #1187 the operator will
require. They also no longer ship with `/tmp/pg_*` directories, since as
of 8fa4a6a (#1185) the operator no longer uses them.
theory added a commit that referenced this pull request Mar 13, 2025
These images include Trunk v0.16.1, which as of #1187 the operator will
require. They also no longer ship with `/tmp/pg_*` directories, since as
of 8fa4a6a (#1185) the operator no longer uses them.

While at it, remove an unnecessary `.to_string()` and the accompanying
linter warning.
theory added a commit that referenced this pull request Mar 13, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations.

Update `check_for_so_files()` to use these methods rather than a
hard-coded directory, and also to include the `.so` file name in the
`ls` command to reduce I/O.

Update `execute_extension_install_command()` to tell `trunk` to install
extension modules into `module_dir`. Requires Trunk v0.16.1.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Update non-test values to reference the new image as defaults. Even
though we're not fully ready to adopt the new image, this change
shouldn't impact things because the stack configurations all define
images.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch from 7ce5382 to 7a7cef1 Compare March 13, 2025 18:36
theory added a commit that referenced this pull request Mar 13, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations.

Update `check_for_so_files()` to use these methods rather than a
hard-coded directory, and also to include the `.so` file name in the
`ls` command to reduce I/O.

Update `execute_extension_install_command()` to tell `trunk` to install
extension modules into `module_dir`. Requires Trunk v0.16.1.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Update non-test values to reference the new image as defaults. Even
though we're not fully ready to adopt the new image, this change
shouldn't impact things because the stack configurations all define
images.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch from 7a7cef1 to 8039877 Compare March 13, 2025 19:48
theory added a commit that referenced this pull request Mar 14, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations.

Update `check_for_so_files()` to use these methods rather than a
hard-coded directory, and also to include the `.so` file name in the
`ls` command to reduce I/O.

Update `execute_extension_install_command()` to tell `trunk` to install
extension modules into `module_dir`. Requires Trunk v0.16.1.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Update non-test values to reference the new image as defaults. Even
though we're not fully ready to adopt the new image, this change
shouldn't impact things because the stack configurations all define
images.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch from 8039877 to 23af159 Compare March 14, 2025 20:41
theory added a commit that referenced this pull request Mar 14, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations.

Update `check_for_so_files()` to use these methods rather than a
hard-coded directory, and also to include the `.so` file name in the
`ls` command to reduce I/O.

Update `execute_extension_install_command()` to tell `trunk` to install
extension modules into `module_dir`. Requires Trunk v0.16.1.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Leave various defaults and tests using the existing images, as more
updates will be needed before we can run the new image, but sync them up
to use the latest image SHA1, the same on found in stack configurations.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch 3 times, most recently from 28c87af to a761cb0 Compare March 17, 2025 16:42
theory added a commit that referenced this pull request Mar 17, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations. Update `check_for_so_files()` to use these
methods rather than a hard-coded directory, and also to include the
`.so` file name in the `ls` command to reduce I/O.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Leave various defaults and tests using the existing images, as more
updates will be needed before we can run the new image, but sync them up
to use the latest image SHA1, the same on found in stack configurations.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch from a761cb0 to b8251f5 Compare March 17, 2025 17:38
theory added a commit that referenced this pull request Mar 17, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations. Update `check_for_so_files()` to use these
methods rather than a hard-coded directory, and also to include the
`.so` file name in the `ls` command to reduce I/O.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Leave various defaults and tests using the existing images, as more
updates will be needed before we can run the new image, but sync them up
to use the latest image SHA1, the same on found in stack configurations.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch from b8251f5 to 7c205a4 Compare March 17, 2025 18:56
theory added a commit that referenced this pull request Mar 17, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations. Update `check_for_so_files()` to use these
methods rather than a hard-coded directory, and also to include the
`.so` file name in the `ls` command to reduce I/O.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Leave various defaults and tests using the existing images, as more
updates will be needed before we can run the new image, but sync them up
to use the latest image SHA1, the same on found in stack configurations.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch from 7c205a4 to 035ff6a Compare March 17, 2025 19:43
theory added a commit that referenced this pull request Mar 17, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations. Update `check_for_so_files()` to use these
methods rather than a hard-coded directory, and also to include the
`.so` file name in the `ls` command to reduce I/O.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Leave various defaults and tests using the existing images, as more
updates will be needed before we can run the new image, but sync them up
to use the latest image SHA1, the same on found in stack configurations.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements` and to include the new module directory in
`dynamic_library_path`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory force-pushed the new-postres-image branch from 035ff6a to ef5e6b9 Compare March 17, 2025 20:54
theory added a commit that referenced this pull request Mar 17, 2025
The new tembo/postgres image stores files in new locations on the
persistent volume, so teach `CoreDBSpec` to recognize the new image and
add the methods `pg_major`, `share_dir`, `module_dir`, and `lib_dir` to
return the proper locations. Update `check_for_so_files()` to use these
methods rather than a hard-coded directory, and also to include the
`.so` file name in the `ls` command to reduce I/O.

Remove the old `postgres_major_version_from_cdb` function, as the
`pg_major` method takes its place (and returns a default rather than an
error when it can't parse the image name for some reason).

Leave various defaults and tests using the existing images, as more
updates will be needed before we can run the new image, but sync them up
to use the latest image SHA1, the same on found in stack configurations.

Also update `tembo-operator/yaml/sample-standard.yaml` to require the
latest `pg_stat_statements`.

Also: the `RolePassword.password` field is never read, so change is name
to `_password` to eliminate warnings.
@theory theory closed this Mar 17, 2025
@theory theory force-pushed the new-postres-image branch from ef5e6b9 to 2befbb0 Compare March 17, 2025 23:01
@theory
Copy link
Contributor Author

theory commented Mar 17, 2025

Was merged in 2befbb0.

@theory theory deleted the new-postres-image branch March 17, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants