Remove release reason for now

Author: Sushisource

core-api/src/worker.rs

@@ -239,7 +239,7 @@ pub trait SlotSupplier {
     fn mark_slot_used(&self, info: <Self::SlotKind as SlotKind>::Info<'_>);
 
     /// Frees a slot.
-    fn release_slot(&self, info: SlotReleaseReason);
+    fn release_slot(&self);
 
     /// If this implementation knows how many slots are available at any moment, it should return
     /// that here.
@@ -279,12 +279,6 @@ impl SlotSupplierPermit {
     }
 }
 
-pub enum SlotReleaseReason {
-    TaskComplete,
-    NeverUsed,
-    Error, // TODO: Details
-}
-
 pub struct WorkflowSlotInfo<'a> {
     pub workflow_type: &'a str,
     // etc...

core/src/abstractions.rs

@@ -12,7 +12,7 @@ use std::{
     },
 };
 use temporal_sdk_core_api::worker::{
-    SlotKind, SlotReleaseReason, SlotReservationContext, SlotSupplier, SlotSupplierPermit,
+    SlotKind, SlotReservationContext, SlotSupplier, SlotSupplierPermit,
 };
 use tokio::sync::watch;
 use tokio_util::sync::CancellationToken;
@@ -125,8 +125,7 @@ where
                 metric_rec(false)
             }),
             release_fn: Box::new(move || {
-                // TODO: Real release reason
-                supp_c_c.release_slot(SlotReleaseReason::TaskComplete);
+                supp_c_c.release_slot();
                 ep_tx_c.send_modify(|ep| *ep -= 1);
                 mrc(true)
             }),

core/src/core_tests/workflow_tasks.rs

@@ -33,8 +33,7 @@ use temporal_sdk_core_api::{
     errors::PollWfError,
     telemetry::metrics::TemporalMeter,
     worker::{
-        SlotKind, SlotReleaseReason, SlotReservationContext, SlotSupplier, SlotSupplierPermit,
-        WorkflowSlotKind,
+        SlotKind, SlotReservationContext, SlotSupplier, SlotSupplierPermit, WorkflowSlotKind,
     },
     Worker as WorkerTrait,
 };
@@ -2899,7 +2898,7 @@ async fn slot_provider_cant_hand_out_more_permits_than_cache_size() {
             Some(SlotSupplierPermit::default())
         }
         fn mark_slot_used(&self, _: <Self::SlotKind as SlotKind>::Info<'_>) {}
-        fn release_slot(&self, _: SlotReleaseReason) {}
+        fn release_slot(&self) {}
         fn available_slots(&self) -> Option<usize> {
             None
         }

core/src/worker/slot_supplier.rs

@@ -1,7 +1,6 @@
 use std::{marker::PhantomData, sync::Arc};
 use temporal_sdk_core_api::worker::{
-    SlotKind, SlotReleaseReason, SlotReservationContext, SlotSupplier, SlotSupplierPermit,
-    WorkerConfigBuilder,
+    SlotKind, SlotReservationContext, SlotSupplier, SlotSupplierPermit, WorkerConfigBuilder,
 };
 use tokio::sync::Semaphore;
 
@@ -48,7 +47,7 @@ where
 
     fn mark_slot_used(&self, _info: SK::Info<'_>) {}
 
-    fn release_slot(&self, _: SlotReleaseReason) {}
+    fn release_slot(&self) {}
 
     fn available_slots(&self) -> Option<usize> {
         Some(self.sem.available_permits())

core/src/worker/slot_supplier/resource_based.rs

@@ -10,9 +10,7 @@ use std::{
 };
 use temporal_sdk_core_api::{
     telemetry::metrics::{CoreMeter, GaugeF64, MetricAttributes, TemporalMeter},
-    worker::{
-        SlotKind, SlotReleaseReason, SlotReservationContext, SlotSupplier, SlotSupplierPermit,
-    },
+    worker::{SlotKind, SlotReservationContext, SlotSupplier, SlotSupplierPermit},
 };
 use tokio::{sync::watch, task::JoinHandle};
 
@@ -159,7 +157,7 @@ where
 
     fn mark_slot_used(&self, _info: SK::Info<'_>) {}
 
-    fn release_slot(&self, _info: SlotReleaseReason) {}
+    fn release_slot(&self) {}
 
     fn attach_metrics(&self, metrics: TemporalMeter) {
         self.inner.attach_metrics(metrics);