Fix lints from new Rust version

Author: Sushisource

core/src/core_tests/workflow_tasks.rs

@@ -1531,7 +1531,7 @@ async fn failing_wft_doesnt_eat_permit_forever() {
                 variant: Some(workflow_activation_job::Variant::RemoveFromCache(_)),
             },]
         );
-        run_id = activation.run_id.clone();
+        run_id.clone_from(&activation.run_id);
         worker
             .complete_workflow_activation(WorkflowActivationCompletion::empty(activation.run_id))
             .await

core/src/lib.rs

@@ -122,7 +122,7 @@ pub(crate) fn init_worker_client(
 ) -> RetryClient<Client> {
     let mut client = Client::new(client, config.namespace.clone());
     if let Some(ref id_override) = config.client_identity_override {
-        client.options_mut().identity = id_override.clone();
+        client.options_mut().identity.clone_from(id_override);
     }
     RetryClient::new(client, RetryConfig::default())
 }

core/src/telemetry/prometheus_server.rs

@@ -20,7 +20,7 @@ pub(super) struct PromServer {
 impl PromServer {
     pub(super) fn new(
         opts: &PrometheusExporterOptions,
-        aggregation: impl AggregationSelector + Send + Sync + 'static,
+        aggregation: impl AggregationSelector + 'static,
     ) -> Result<(Self, PrometheusExporter), anyhow::Error> {
         let registry = Registry::new();
         let exporter = opentelemetry_prometheus::exporter()

core/src/worker/workflow/machines/activity_state_machine.rs

@@ -28,7 +28,7 @@ use temporal_sdk_core_protos::{
         history::v1::{
             history_event, ActivityTaskCanceledEventAttributes,
             ActivityTaskCompletedEventAttributes, ActivityTaskFailedEventAttributes,
-            ActivityTaskTimedOutEventAttributes, HistoryEvent,
+            ActivityTaskTimedOutEventAttributes,
         },
     },
 };
@@ -286,19 +286,6 @@ impl WFMachinesAdapter for ActivityMachine {
             }
         })
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        matches!(
-            event.event_type(),
-            EventType::ActivityTaskScheduled
-                | EventType::ActivityTaskStarted
-                | EventType::ActivityTaskCompleted
-                | EventType::ActivityTaskFailed
-                | EventType::ActivityTaskTimedOut
-                | EventType::ActivityTaskCancelRequested
-                | EventType::ActivityTaskCanceled
-        )
-    }
 }
 
 impl TryFrom<CommandType> for ActivityMachineEvents {

core/src/worker/workflow/machines/cancel_external_state_machine.rs

@@ -14,7 +14,7 @@ use temporal_sdk_core_protos::{
         command::v1::{command, Command, RequestCancelExternalWorkflowExecutionCommandAttributes},
         enums::v1::{CancelExternalWorkflowExecutionFailedCause, CommandType, EventType},
         failure::v1::{failure::FailureInfo, ApplicationFailureInfo, Failure},
-        history::v1::{history_event, HistoryEvent},
+        history::v1::history_event,
     },
 };
 
@@ -210,15 +210,6 @@ impl WFMachinesAdapter for CancelExternalMachine {
             }
         })
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        matches!(
-            event.event_type(),
-            EventType::ExternalWorkflowExecutionCancelRequested
-                | EventType::RequestCancelExternalWorkflowExecutionFailed
-                | EventType::RequestCancelExternalWorkflowExecutionInitiated
-        )
-    }
 }
 
 impl Cancellable for CancelExternalMachine {}

core/src/worker/workflow/machines/cancel_workflow_state_machine.rs

@@ -1,6 +1,6 @@
 use super::{
-    workflow_machines::MachineResponse, Cancellable, EventInfo, HistoryEvent,
-    NewMachineWithCommand, OnEventWrapper, WFMachinesAdapter, WFMachinesError,
+    workflow_machines::MachineResponse, Cancellable, EventInfo, NewMachineWithCommand,
+    OnEventWrapper, WFMachinesAdapter, WFMachinesError,
 };
 use crate::worker::workflow::machines::HistEventData;
 use rustfsm::{fsm, StateMachine, TransitionResult};
@@ -27,9 +27,6 @@ fsm! {
         --> CancelWorkflowCommandRecorded;
 }
 
-#[derive(thiserror::Error, Debug)]
-pub(super) enum CancelWorkflowMachineError {}
-
 #[derive(Debug, derive_more::Display)]
 pub(super) enum CancelWorkflowCommand {}
 
@@ -105,10 +102,6 @@ impl WFMachinesAdapter for CancelWorkflowMachine {
     ) -> Result<Vec<MachineResponse>, WFMachinesError> {
         Ok(vec![])
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        event.event_type() == EventType::WorkflowExecutionCanceled
-    }
 }
 
 impl Cancellable for CancelWorkflowMachine {}

core/src/worker/workflow/machines/child_workflow_state_machine.rs

@@ -38,7 +38,7 @@ use temporal_sdk_core_protos::{
         history::v1::{
             history_event, ChildWorkflowExecutionCompletedEventAttributes,
             ChildWorkflowExecutionFailedEventAttributes,
-            ChildWorkflowExecutionStartedEventAttributes, HistoryEvent,
+            ChildWorkflowExecutionStartedEventAttributes,
             StartChildWorkflowExecutionFailedEventAttributes,
         },
     },
@@ -283,7 +283,7 @@ impl StartEventRecorded {
         event: ChildWorkflowExecutionStartedEvent,
     ) -> ChildWorkflowMachineTransition<Started> {
         state.started_event_id = event.started_event_id;
-        state.run_id = event.workflow_execution.run_id.clone();
+        state.run_id.clone_from(&event.workflow_execution.run_id);
         ChildWorkflowMachineTransition::commands(vec![ChildWorkflowCommand::Start(
             event.workflow_execution,
         )])
@@ -704,20 +704,6 @@ impl WFMachinesAdapter for ChildWorkflowMachine {
             }
         })
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        matches!(
-            event.event_type(),
-            EventType::StartChildWorkflowExecutionInitiated
-                | EventType::StartChildWorkflowExecutionFailed
-                | EventType::ChildWorkflowExecutionStarted
-                | EventType::ChildWorkflowExecutionCompleted
-                | EventType::ChildWorkflowExecutionFailed
-                | EventType::ChildWorkflowExecutionTimedOut
-                | EventType::ChildWorkflowExecutionTerminated
-                | EventType::ChildWorkflowExecutionCanceled
-        )
-    }
 }
 
 impl TryFrom<CommandType> for ChildWorkflowMachineEvents {

core/src/worker/workflow/machines/complete_workflow_state_machine.rs

@@ -10,7 +10,6 @@ use temporal_sdk_core_protos::{
     temporal::api::{
         command::v1::Command,
         enums::v1::{CommandType, EventType},
-        history::v1::HistoryEvent,
     },
 };
 
@@ -103,9 +102,6 @@ impl Created {
     }
 }
 
-#[derive(thiserror::Error, Debug)]
-pub(super) enum CompleteWorkflowMachineError {}
-
 #[derive(Default, Clone)]
 pub(super) struct CompleteWorkflowCommandCreated {}
 
@@ -126,10 +122,6 @@ impl WFMachinesAdapter for CompleteWorkflowMachine {
     ) -> Result<Vec<MachineResponse>, WFMachinesError> {
         Ok(vec![])
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        event.event_type() == EventType::WorkflowExecutionCompleted
-    }
 }
 
 impl Cancellable for CompleteWorkflowMachine {}

core/src/worker/workflow/machines/continue_as_new_workflow_state_machine.rs

@@ -1,5 +1,5 @@
 use super::{
-    Cancellable, EventInfo, HistoryEvent, MachineResponse, NewMachineWithCommand, OnEventWrapper,
+    Cancellable, EventInfo, MachineResponse, NewMachineWithCommand, OnEventWrapper,
     WFMachinesAdapter, WFMachinesError,
 };
 use crate::worker::workflow::machines::HistEventData;
@@ -107,10 +107,6 @@ impl WFMachinesAdapter for ContinueAsNewWorkflowMachine {
     ) -> Result<Vec<MachineResponse>, WFMachinesError> {
         Ok(vec![])
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        event.event_type() == EventType::WorkflowExecutionContinuedAsNew
-    }
 }
 
 impl Cancellable for ContinueAsNewWorkflowMachine {}

core/src/worker/workflow/machines/fail_workflow_state_machine.rs

@@ -10,7 +10,6 @@ use temporal_sdk_core_protos::{
     temporal::api::{
         command::v1::Command as ProtoCommand,
         enums::v1::{CommandType, EventType},
-        history::v1::HistoryEvent,
     },
 };
 
@@ -117,10 +116,6 @@ impl WFMachinesAdapter for FailWorkflowMachine {
     ) -> Result<Vec<MachineResponse>, WFMachinesError> {
         Ok(vec![])
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        event.event_type() == EventType::WorkflowExecutionFailed
-    }
 }
 
 impl Cancellable for FailWorkflowMachine {}

core/src/worker/workflow/machines/local_activity_state_machine.rs

@@ -34,7 +34,6 @@ use temporal_sdk_core_protos::{
         command::v1::{command, RecordMarkerCommandAttributes},
         enums::v1::{CommandType, EventType, RetryState},
         failure::v1::{failure::FailureInfo, Failure},
-        history::v1::HistoryEvent,
     },
     utilities::TryIntoOrNone,
 };
@@ -799,10 +798,6 @@ impl WFMachinesAdapter for LocalActivityMachine {
             }
         }
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        event.is_local_activity_marker()
-    }
 }
 
 impl TryFrom<CommandType> for LocalActivityMachineEvents {

core/src/worker/workflow/machines/mod.rs

@@ -84,11 +84,6 @@ trait TemporalStateMachine {
         command_type: CommandType,
     ) -> Result<Vec<MachineResponse>, WFMachinesError>;
 
-    /// Returns true if this machine is compatible with the provided event. Provides a way to know
-    /// ahead of time if it's worth trying to call [TemporalStateMachine::handle_event] without
-    /// requiring mutable access.
-    fn matches_event(&self, event: &HistoryEvent) -> bool;
-
     /// Tell the state machine to handle some event. Returns a list of responses that can be used
     /// to update the overall state of the workflow. EX: To issue outgoing WF activations.
     fn handle_event(
@@ -150,10 +145,6 @@ where
         }
     }
 
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        self.matches_event(event)
-    }
-
     fn handle_event(
         &mut self,
         event_dat: HistEventData,
@@ -240,11 +231,6 @@ trait WFMachinesAdapter: StateMachine {
         my_command: Self::Command,
         event_info: Option<EventInfo>,
     ) -> Result<Vec<MachineResponse>, WFMachinesError>;
-
-    /// Returns true if this machine is compatible with the provided event. Provides a way to know
-    /// ahead of time if it's worth trying to call [TemporalStateMachine::handle_event] without
-    /// requiring mutable access.
-    fn matches_event(&self, event: &HistoryEvent) -> bool;
 }
 
 /// Wraps a history event with extra relevant data that a machine might care about while the event

core/src/worker/workflow/machines/modify_workflow_properties_state_machine.rs

@@ -9,7 +9,6 @@ use temporal_sdk_core_protos::{
     temporal::api::{
         command::v1::Command,
         enums::v1::{CommandType, EventType},
-        history::v1::HistoryEvent,
     },
 };
 
@@ -63,10 +62,6 @@ impl WFMachinesAdapter for ModifyWorkflowPropertiesMachine {
             "ModifyWorkflowProperties does not use state machine commands".to_string(),
         ))
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        matches!(event.event_type(), EventType::WorkflowPropertiesModified)
-    }
 }
 
 impl Cancellable for ModifyWorkflowPropertiesMachine {}

core/src/worker/workflow/machines/patch_state_machine.rs

@@ -46,7 +46,6 @@ use temporal_sdk_core_protos::{
         },
         common::v1::SearchAttributes,
         enums::v1::CommandType,
-        history::v1::HistoryEvent,
     },
 };
 
@@ -237,10 +236,6 @@ impl WFMachinesAdapter for PatchMachine {
     ) -> Result<Vec<MachineResponse>, WFMachinesError> {
         panic!("Patch machine does not produce commands")
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        event.get_patch_marker_details().is_some()
-    }
 }
 
 impl Cancellable for PatchMachine {}

core/src/worker/workflow/machines/signal_external_state_machine.rs

@@ -19,7 +19,7 @@ use temporal_sdk_core_protos::{
         common::v1::WorkflowExecution as UpstreamWE,
         enums::v1::{CommandType, EventType, SignalExternalWorkflowExecutionFailedCause},
         failure::v1::{failure::FailureInfo, ApplicationFailureInfo, CanceledFailureInfo, Failure},
-        history::v1::{history_event, HistoryEvent},
+        history::v1::history_event,
     },
 };
 
@@ -260,15 +260,6 @@ impl WFMachinesAdapter for SignalExternalMachine {
             }
         })
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        matches!(
-            event.event_type(),
-            EventType::ExternalWorkflowExecutionSignaled
-                | EventType::SignalExternalWorkflowExecutionInitiated
-                | EventType::SignalExternalWorkflowExecutionFailed
-        )
-    }
 }
 
 impl Cancellable for SignalExternalMachine {

core/src/worker/workflow/machines/timer_state_machine.rs

@@ -16,7 +16,7 @@ use temporal_sdk_core_protos::{
     temporal::api::{
         command::v1::Command,
         enums::v1::{CommandType, EventType},
-        history::v1::{history_event, HistoryEvent, TimerFiredEventAttributes},
+        history::v1::{history_event, TimerFiredEventAttributes},
     },
 };
 
@@ -233,13 +233,6 @@ impl WFMachinesAdapter for TimerMachine {
             TimerMachineCommand::IssueCancelCmd(c) => vec![MachineResponse::IssueNewCommand(c)],
         })
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        matches!(
-            event.event_type(),
-            EventType::TimerStarted | EventType::TimerCanceled | EventType::TimerFired
-        )
-    }
 }
 
 impl Cancellable for TimerMachine {

core/src/worker/workflow/machines/update_state_machine.rs

@@ -17,7 +17,6 @@ use temporal_sdk_core_protos::{
         common::v1::Payload,
         enums::v1::{CommandType, EventType},
         failure::v1::Failure,
-        history::v1::HistoryEvent,
         protocol::v1::Message as ProtocolMessage,
         update::v1::{outcome, Acceptance, Outcome, Rejection, Response},
     },
@@ -271,15 +270,6 @@ impl WFMachinesAdapter for UpdateMachine {
             )?,
         })
     }
-
-    fn matches_event(&self, event: &HistoryEvent) -> bool {
-        matches!(
-            event.event_type(),
-            EventType::WorkflowExecutionUpdateAccepted
-                | EventType::WorkflowExecutionUpdateRejected
-                | EventType::WorkflowExecutionUpdateCompleted
-        )
-    }
 }
 
 impl TryFrom<CommandType> for UpdateMachineEvents {