Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer create project should support --prefer-dist #19

Open
Toflar opened this issue Jul 6, 2016 · 7 comments
Open

Composer create project should support --prefer-dist #19

Toflar opened this issue Jul 6, 2016 · 7 comments

Comments

@Toflar
Copy link
Contributor

Toflar commented Jul 6, 2016

Otherwise the install process is cloning by default.

@discordier
Copy link
Member

We will then most likely also need a way to specify the github token. Otherwise it will not help much to prefer dist.

@discordier
Copy link
Member

Eh, it already is there... has been introduced by @aschempp in d275f11.
Is it not working for you?

@Toflar
Copy link
Contributor Author

Toflar commented Jul 11, 2016

Task 031fc20d6a8d2086f62d20b5a50d8de9 started.
Installing contao/standard-edition (4.2.0)
  - Installing contao/standard-edition (4.2.0)
    Downloading: Connecting...    Downloading: 100%

Created project in /Users/yanickwitschi/Sites/contao-manager/test-dir/install-5783597a8dc04
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
  - Installing contao-components/installer (1.2.3)
    Cloning 14c7b1f199c76890446ae088ed8b24741662065d

  - Installing contao-components/tinymce4 (4.3.4.1)
    Cloning 55ee8751b707c7c743090ba21b8e5079059a0171

  - Installing contao-components/tablesorter (2.0.5.3)
    Cloning 14146cc04c1f089fa6111fb9e56fd3a476701bbd

  - Installing contao-components/tablesort (3.4.5)
    Cloning 019cdf981a5c49627b47f25e3d38b67f3c0fdf1d

  - Installing contao-components/swipe (2.0.6)
    Cloning 3da33929d52af5f54e4bb68e849ee9ac0d99edcf

// etc.

I would like to provide you with the exact task command that was executed but unfortunately these are not logged (yet?).

@discordier
Copy link
Member

Well, it is downloading in the beginning and then reverts to cloning. I suspect because of API limit and no oauth token.

@Toflar
Copy link
Contributor Author

Toflar commented Jul 12, 2016

I see. We need to add that then, although I don't know where to place that in the UI on the install screen (once installed, we can put it to the configuration page, yes).

@Toflar
Copy link
Contributor Author

Toflar commented Jul 18, 2016

Not sure if this is the case. Also it says Updating dependencies (including require-dev) which according to @aschempp's commit should not be the case either?

@Toflar
Copy link
Contributor Author

Toflar commented Jul 18, 2016

Ah, this is the install task, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants