Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The floor value for clipping in SamplingProbablityCorrection could be too high for larger datasets #588

Open
aismlv opened this issue Nov 29, 2022 · 0 comments

Comments

@aismlv
Copy link

aismlv commented Nov 29, 2022

Hi,

The current value of 1e-6 is set here. The rationale seems to be to avoid zeros but the value set could be too high for larger datasets and result in lower metrics on a private dataset. This stops us from updating the package to versions >0.6.0. What would be the best way to address it?

One way could be to set a lower value as suggested here. Also, there seems to be a typo in the naming of the class that's already addressed in another PR that hasn't been merged yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant