-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove [gcp]
from requirements for apache-beam[gcp]
#5782
Comments
Hi @ammarck, We are discussing your proposal, and had some questions:
|
@rcrowe-google hi!
By the way, the problem of |
Hi @ammarck, Good point about the other packages! You're correct that in order to really eliminate the dependency on GCP those other packages will also need to be updated to include that option. However, while we may be able to update TFX to make these changes (and this is far from certain), we are very unlikely to be able to make the required changes in the other packages due to resource issues on those teams. In the original comment you replied "Are you willing to contribute it (Yes/No): Yes". Does that mean that you are willing to submit a PR to make these changes? If so, please don't start writing code right away, we need to go through a process. |
System information
(Linux/MacOS/Windows), Interactive Notebook, Google Cloud, etc..): Azure
Describe the feature and the current behavior/state.
Removing
[gcp]
fromapache-beam[gcp]
insetup.py
and all downstream projects.We are big users of TFX in our company, however, we do not run on GCP. The problem we run into is we get a lot of python package conflicts because of that. The use of
[gcp]
should be optional and not a requirement.What can be done, is to make
tfx[gcp]
importapache-beam[gcp]
, however, right nowtfx
importsapache-beam[gcp]
by default.Will this change the current API? How?
No
Who will benefit with this feature?
Everyone who uses TFX but do not use GCP.
Do you have a workaround or are completely blocked by this? :
Right now completely blocked. I tried to patch each TFX library to remove
apache-beam[gcp]
however I ran into problems when I tried to patch data-validation, I got errors when I tried to build.Name of your Organization (Optional)
Any Other info.
The text was updated successfully, but these errors were encountered: