Skip to content

Commit e9c17cf

Browse files
committed
feat: add backwards compatibility to the service block
1 parent 85a9d57 commit e9c17cf

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

examples/fargate/main.tf

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -126,16 +126,14 @@ module "ecs_service" {
126126

127127
service_connect_configuration = {
128128
namespace = aws_service_discovery_http_namespace.this.arn
129-
service = [
130-
{
131-
client_alias = {
132-
port = local.container_port
133-
dns_name = local.container_name
134-
}
135-
port_name = local.container_name
136-
discovery_name = local.container_name
129+
service = {
130+
client_alias = {
131+
port = local.container_port
132+
dns_name = local.container_name
137133
}
138-
]
134+
port_name = local.container_name
135+
discovery_name = local.container_name
136+
}
139137
}
140138

141139
load_balancer = {

modules/service/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ resource "aws_ecs_service" "this" {
153153
namespace = lookup(service_connect_configuration.value, "namespace", null)
154154

155155
dynamic "service" {
156-
for_each = try(service_connect_configuration.value.service, [])
156+
for_each = try(lookup(service_connect_configuration.value.service, "port_name") != null ? [service_connect_configuration.value.service] : [], try(service_connect_configuration.value.service, []))
157157

158158
content {
159159

@@ -339,7 +339,7 @@ resource "aws_ecs_service" "ignore_task_definition" {
339339
namespace = lookup(service_connect_configuration.value, "namespace", null)
340340

341341
dynamic "service" {
342-
for_each = try(service_connect_configuration.value.service, [])
342+
for_each = try(lookup(service_connect_configuration.value.service, "port_name") != null ? [service_connect_configuration.value.service] : [], try(service_connect_configuration.value.service, []))
343343

344344
content {
345345

0 commit comments

Comments
 (0)