Skip to content
This repository has been archived by the owner on Nov 17, 2021. It is now read-only.

Fix review feedback/comments #2

Open
morgante opened this issue Dec 2, 2019 · 0 comments · May be fixed by #6
Open

Fix review feedback/comments #2

morgante opened this issue Dec 2, 2019 · 0 comments · May be fixed by #6
Assignees
@omazin
Labels
P4 triaged

Comments

@morgante
Copy link
Contributor

morgante commented Dec 2, 2019

The initial PR was merged without fixing feedback, we need to fix it/incorporate the provided feedback: #1
morgante pushed a commit that referenced this issue Dec 2, 2019
@kumary
Merge pull request #2 from kumary/dev
aed49be 
124371356 : Created Dev branch and copied memcached code from private…
@morgante morgante added the P4 label Dec 2, 2019
@omazin omazin self-assigned this Dec 10, 2019
omazin added a commit to omazin/terraform-google-memcached that referenced this issue Dec 13, 2019
@omazin
Rewrite module. Fix terraform-google-modules#2. Upgrade to tf 0.12. Fix
7a8ea21 
terraform-google-modules#4. Add example, test. Add integration, linting build configurations.
@omazin omazin linked a pull request Dec 13, 2019 that will close this issue
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@omazin omazin

Labels
P4 triaged
Projects
None yet
Milestone
No milestone
3 participants
@morgante @aaron-lane @omazin