feat: add pooling configuration for postgresql and mysql #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichbinfrog
requested review from
a team,
ayushmjain,
imrannayer and
q2w
as code owners
Contributor
|
@bharathkkb here too please |
|
+1 looking forward to this feature as well. |
Collaborator
|
@ichbinfrog thx for the PR. Can you plz add this feature to safer mysql module? |
ichbinfrog
force-pushed
the
pooling-config
branch
from
14b95eb to
c724c62
Compare
Author
|
My bad @imrannayer , it's been added 🙏 |
|
+1 do you have any ideas on when this could be added, really looking forward for this feature to be available |
Collaborator
|
@ichbinfrog can you plz resolve conflicts? |
ichbinfrog
force-pushed
the
pooling-config
branch
from
c724c62 to
ed675cf
Compare
Signed-off-by: Quoc Trung HOANG <quoc-trung.hoang@webedia-group.com>
Collaborator
|
/gcbrun |
imrannayer
reviewed
Dec 2, 2025
| default = [] | ||
| } | ||
|
|
||
| variable "connection_pool_config" { |
Collaborator
There was a problem hiding this comment.
@ichbinfrog is it a required variable? It is not required in postgres module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managed Connection pooling is now GA.
The terraform resource
google_sql_database_instancealready supports it