Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

feat: existing scc instance for DA #8

Closed
wants to merge 13 commits into from
Closed

feat: existing scc instance for DA #8

wants to merge 13 commits into from

Conversation

jor2
Copy link
Member

@jor2 jor2 commented Aug 2, 2024

Description

Enable skipping SCC provisioning
terraform-ibm-modules#131

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

enable skipping SCC provisioning by providing option for passing existing scc instance id.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Aug 2, 2024
@ocofaigh
Copy link
Member

ocofaigh commented Aug 2, 2024

@jor2 can you create a PR in https://github.com/terraform-ibm-modules/stack-ibm-core-security-services with the same change. That repo has a test to test existing resources, so you can update the test to pass it so we test the use case in the stack.
This repo does not yet have a test to test existing resource (tracked here), so at least we could use the other repo to test first.

@ocofaigh ocofaigh requested review from akocbek and in-1911 and removed request for daniel-butler-irl and ocofaigh August 12, 2024 14:53
@jor2
Copy link
Member Author

jor2 commented Aug 14, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Aug 19, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Aug 20, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Aug 26, 2024

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Aug 28, 2024

/run pipeline

Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the stack definition and add AI Security Guardrails 2.0 as inout to SCC DA

@jor2
Copy link
Member Author

jor2 commented Aug 30, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Aug 30, 2024

/run pipeline

@ocofaigh
Copy link
Member

@jor2 FYI, we are no longer going to merge any PRs for the basic (code engine) variation in this repo. All new PRs will go directly into the original RAG repo once terraform-ibm-modules#180 is merged.

FYI, I expect the pipeline to fail due to the SCC bug. The AI Security Guardrails 2.0 profile is also impacted

@jor2 jor2 closed this Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants