Skip to content

refactor: support creating only one project #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 10, 2025
Merged

refactor: support creating only one project #146

merged 17 commits into from
Feb 10, 2025

Conversation

Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Dec 31, 2024

Description

Issue: #134

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

│ Error: Value for undeclared variable
│ 
│ A variable named "project_name" was assigned on the command line, but the
│ root module does not declare a variable of that name. To use this value,
│ add a "variable" block to the configuration.
╵
╷
│ Error: No value for required variable
│ 
│   on variables.tf line 44:
│   44: variable "project_names" {
│ 
│ The root module input variable "project_names" is not set, and has no
│ default value. Use a -var or -var-file command line argument to provide a
│ value for this variable.
╵}

will need to skip the upgrade test

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 7, 2025

/run pipeline

shemau
shemau previously approved these changes Jan 7, 2025
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me and IMHO should be merged as is. This will be breaking change for the DA, in that both inputs and outputs are changed (which should be included in the release notes section of the description of the PR), so best to get it in quick.

This only partially addresses the issue, which also requests other code engine project features, all of which are plural and thus require complex inputs and maybe outputs.

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 8, 2025

on a second thought, should we add a moved block to prevent at least the first project from being recreated.

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 9, 2025

/run pipeline

@Aashiq-J
Copy link
Member Author

Aashiq-J commented Jan 9, 2025

/run pipeline

@Aashiq-J Aashiq-J requested a review from shemau January 9, 2025 05:32
shemau
shemau previously requested changes Jan 10, 2025
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J Aashiq-J requested a review from shemau January 23, 2025 03:27
Copy link
Contributor

@akocbek akocbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aashiq-J small comment

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

1 similar comment
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit d95ca6b into main Feb 10, 2025
2 checks passed
@ocofaigh ocofaigh deleted the projects-ref branch February 10, 2025 17:09
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants