-
Notifications
You must be signed in to change notification settings - Fork 5
refactor: support creating only one project #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/run pipeline |
/run pipeline |
/run pipeline |
will need to skip the upgrade test |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me and IMHO should be merged as is. This will be breaking change for the DA, in that both inputs and outputs are changed (which should be included in the release notes section of the description of the PR), so best to get it in quick.
This only partially addresses the issue, which also requests other code engine project features, all of which are plural and thus require complex inputs and maybe outputs.
on a second thought, should we add a moved block to prevent at least the first project from being recreated. |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aashiq-J small comment
/run pipeline |
/run pipeline |
1 similar comment
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
🎉 This PR is included in version 3.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Issue: #134
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers