Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating tim repos to pull cra config from a file #135

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Conversation

Khuzaima05
Copy link
Member

@Khuzaima05 Khuzaima05 commented Nov 22, 2023

Description

migrating tim repos to pull cra config from a file

issue : https://github.ibm.com/GoldenEye/issues/issues/5569

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 self-assigned this Nov 22, 2023
@Khuzaima05 Khuzaima05 marked this pull request as ready for review November 22, 2023 11:03
@Khuzaima05 Khuzaima05 requested a review from ocofaigh November 22, 2023 13:22
@ocofaigh ocofaigh merged commit cd2fbca into main Nov 23, 2023
@ocofaigh ocofaigh deleted the issue_5569 branch November 23, 2023 17:35
Copy link
Member

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Khuzaima05 I just realised you never migrated the craEnvironmentVariables into the yaml. Please create a new PR to do this, or pipeline will be blocked

@Khuzaima05
Copy link
Member Author

PR : #138

@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.4.12 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants