Default values for variables removed

[marifse]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[marifse]

@ocofaigh can you please check and verify.

[ocofaigh]

@marifse I left one comment. Also adding @SirSpidey as reviewer for the wording you are adding

[SirSpidey]

small editorial suggestions

[marifse]

@marifse I left one comment. Also adding @SirSpidey as reviewer for the wording you are adding

@ocofaigh can you please check now, requested fixes have been addressed.

[SirSpidey]

👍

[shemau]

Completing the description and referencing any issues might have helped understand. I did look for kms default issues and found none, but that may have been my search.

[ocofaigh]

/run pipeline

[ocofaigh]

region and prefix values need to be added as TF_VARs in cra-config.yaml now that they are required vars in the example being scanned.

[marifse]

region and prefix values need to be added as TF_VARs in cra-config.yaml now that they are required vars in the example being scanned.

@ocofaigh values for region and prefix in cra-config.yml have been added.

[ocofaigh]

these are not in correct place in yaml. They need to be under CRA_ENVIRONMENT_VARIABLES. See the commented out code below this

[marifse]

@ocofaigh fixed.

[ocofaigh]

/run pipeline

[ocofaigh]

@marifse Looks like your PR contains an old version of the common-dev-assets git submodule, and so pipeline is failing. I suggest you don't commit updates to common-dev-assets to avoid this issue. Please follow the steps below:

Detected common-dev-assets git submodule commit ID is older than the one in primary branch. To fix:
  1. Record the current state of the working directory:
      i. git stash
  2. Ensure that your local primary branch is up to date:
      i. git checkout <master / main>
      ii. git pull origin <master / main>
      iii. git submodule update --rebase
  3. Make sure your dev branch is rebased with remote primary branch:
      i. git checkout <dev-branch>
      ii. git stash pop
      iii. git pull origin <master / main>
  4. Run the following command to sync the git submodule with primary branch:
      i. git submodule update --rebase