-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cover gap when only creating an adapter/resolve sensitive key bug #657
Conversation
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Might consider some comments on the local that say what is in the resulting map, the nested for loops with conditional logic can be hard to comprehend.
/run pipeline |
🎉 This PR is included in version 1.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Found a bug when not provisioning a KMIP certificate but an adapter is created which attempts to index a null value, added a check and an extra key in the example to test for this gap
Also updated the kmip adapter/cert local map creation to mark the keys used as nonsensitive and added the sensitive flag to the variable
Release required?
x.x.X
)x.X.x
)X.x.x
)Release notes content
Fix an error when only creating a KMIP adapter and not adding any certificates
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers