Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cover gap when only creating an adapter/resolve sensitive key bug #657

Merged
merged 8 commits into from
Jan 16, 2025

Conversation

MatthewLemmond
Copy link
Member

@MatthewLemmond MatthewLemmond commented Dec 20, 2024

Description

Found a bug when not provisioning a KMIP certificate but an adapter is created which attempts to index a null value, added a check and an extra key in the example to test for this gap

Also updated the kmip adapter/cert local map creation to mark the keys used as nonsensitive and added the sensitive flag to the variable

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Fix an error when only creating a KMIP adapter and not adding any certificates

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond
Copy link
Member Author

/run pipeline

@MatthewLemmond MatthewLemmond changed the title fix: cover gap when only creating an adapter fix: cover gap when only creating an adapter/resolve sensitive key bug Jan 14, 2025
@MatthewLemmond
Copy link
Member Author

/run pipeline

shemau
shemau previously approved these changes Jan 14, 2025
Copy link

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might consider some comments on the local that say what is in the resulting map, the nested for loops with conditional logic can be hard to comprehend.

@MatthewLemmond
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit 825452d into main Jan 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the kmip-bugfix branch January 16, 2025 11:40
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants