Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] Avoid Duplicate Discoveries #73

Open
pr0me opened this issue Mar 11, 2024 · 0 comments
Open

[Discovery] Avoid Duplicate Discoveries #73

pr0me opened this issue Mar 11, 2024 · 0 comments

Comments

@pr0me
Copy link
Contributor

pr0me commented Mar 11, 2024

Problem description:
For patterns that have multiple instances that all show to the same discovery rule, there will be multiple identical entries in the discovery file. This is expected but confusing, I think.

Having multiple patterns with the same discovery rule is the outcome of a past discussion: In such cases, the instances and their code snippets act a examples of different manifestations of a testability pattern but have the same underlying problem on a code/CPG level.

Suggested solution:
During pattern discovery, collect individual discoveries as a set instead of a list, eliminating exact duplicates in the discovery report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant