Fix duct-tape:1.0.8 Zombie thread#9241
Open
dadoonet wants to merge 6 commits intotestcontainers:mainfrom
Open
Conversation
1st step: move code from the archived repository Related to testcontainers#9227.
2nd step: call shutdown() when stopping the container Related to testcontainers#9227.
|
@dadoonet @eddumelendez , sorry for the ping -- is there any help that we could give to get this one merged? I offer a genuine-human-spotted-and-crafted-bug-fix as initial offering testcontainers/testcontainers-site#252 |
Demonstrates that calling Timeouts.shutdown() (as GenericContainer.stop() does in this PR) permanently kills the static shared ExecutorService, causing all subsequent Timeouts usage to fail with RejectedExecutionException. This breaks any test suite that stops one container and then starts another. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the static final ExecutorService with a lazily-created one so that shutdown() doesn't permanently break subsequent container operations. The executor is re-created transparently on next use. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Zombie threads poc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a naive implementation for the bug described in #9227.
I basically moved the code from https://github.com/rnorth/duct-tape/ to
org.testcontainers.utility.ducttapeTC new package. And I removed the dependency on theduct-tapejar.Then I added a method
Timeouts.shutdown()which basically calls theshutdown()method on the Thread.Finally, when we stop a container, I'm calling this
Timeouts.shutdown().This should close the remaining thread.
Let me know what you think and if I should continue on this path or not.
Thanks!