-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference to undefined variable git_work_tree
in Target Platform
#53
Comments
Update: apparently it works with <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="Kura Target Platform Equinox 3.16.0" sequenceNumber="47">
<locations>
<location path="${project_loc:kura/target-definition}/target-definition/common/repository/plugins" type="Directory"/>
<location path="${project_loc:kura/target-definition}/target-definition/equinox_3.16.0/repository/plugins" type="Directory"/>
<location path="${project_loc:kura/target-definition}/target-definition/test-deps/repository/plugins" type="Directory"/>
</locations>
</target> and also with: <?xml version="1.0" encoding="UTF-8" standalone="no"?><?pde version="3.8"?><target name="Kura Target Platform Equinox 3.16.0" sequenceNumber="47">
<locations>
<location path="${container_loc:/kura/target-definition/common/repository/plugins}" type="Directory"/>
<location path="${container_loc:/kura/target-definition/equinox_3.16.0/repository/plugins}" type="Directory"/>
<location path="${container_loc:/kura/target-definition/test-deps/repository/plugins}" type="Directory"/>
</locations>
</target> but, the first time the project is opened with VSCode, the Java build fails and the LSP log reports the same errors as per my first comment. If you
the build succeeds and the diagnostics are working properly. Note: This is only needed once. When you first open the project with VSCode. |
Since vscode-pde extension uses the same pde plugins as Eclipse, I'm wondering if Eclipse can support such variable references in tp file well?
Yes, reloading VS Code is a good workaround. Sometimes vscode-pde still uses the old tp contents from the cache, and reloading VS Code can usually solve it. |
Well... these variables are the one provided in the dedicated UI.
Actually it looks like as if they're not populated the first time you open the project. Upon reloading they're populated and everything is resolved correctly... Edit: Looks like this is a long-standing bug in the Eclipse codebase: https://bugs.eclipse.org/bugs/show_bug.cgi?id=501393 |
@testforstephen I performed a couple more experiments and I think the only real issue/weird behaviour is the fact that it doesn't recognize the As a workaround for our project, I think we'll stick with the Feel free to close this if you think this can be good approach for anyone with the same issue. Anyway, thanks for your feedback :) |
git_work_tree
in Target Platform
Good findings. I will close it since you have a workaround. If we receive more feedback from other users with similar use cases, we can revisit it again. |
Hello there,
first and foremost: thank you for this awesome extension!
I encountered this issue while adding VSCode support to our project. Details here.
I'm using vscode-pde extension with Language Support for Java(TM) by Red Hat to achieve this.
Our current target definition looks like this:
When I open the project with VSCode as-is I get:
See full log
To circumvent the issue I tried
${project_loc}
and${container_loc}
variables without luck.${project_loc}
Results in:
See full log
${container_loc}
Results in:
See full log
What am I doing wrong? Is there a way around this?
Our workaround for now is substituting the variables with the absolute path, but this is not portable...
I opened this originally on the jdt.ls repo but was redirected here from the maintainers.
The text was updated successfully, but these errors were encountered: