Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: make upset axes #38

Open
teunbrand opened this issue Dec 16, 2024 · 3 comments
Open

Idea: make upset axes #38

teunbrand opened this issue Dec 16, 2024 · 3 comments
Labels
💡 feature New feature or request

Comments

@teunbrand
Copy link
Owner

Essentially a discrete axis as made by {ggupset}, but not tied to a scale or upset logic. Can also be just unconnected points for boolean values or coloured points to overlay some categorical value.

@teunbrand teunbrand added the 💡 feature New feature or request label Dec 16, 2024
@const-ae
Copy link

const-ae commented Jan 7, 2025

Hi Teun, I just saw this issue and wanted to say that legendry feels like a great place to standardize my approach from ggupset! My mental model for ggupset is that it is just a pretty display of compound axis labels like "Drama", "Drama|Comedy", "Romance", "Drama|Romance" etc..

Taking this one step further, do you think legendry could accommodate completely arbitrary plots as shown here? My naive understanding is that this could be a new type of guide which accepts a function that produces a plot and receives the limits. For axis guides, one would need to ensure that the output is correctly aligned, and for legend guides one would need to think through how to do the layouting.

@teunbrand
Copy link
Owner Author

Hi Constantin!

Yeah an upset axis is a neat graphical ideom to display categorical combinations. I much prefer ggupset over upsetR as it better sticks to ggplot2's grammar :)

In a way, legendry::gizmo_grob() already supports arbitrary grobs, which can be plots via ggplot2::ggplotGrob(). But perhaps a more specialised guide function including aligning the limits could be put to better use. I'll open a separate issue for this!

@const-ae
Copy link

const-ae commented Jan 7, 2025

Sounds great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants