Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid automatic semicolon insertion (ASI) hazard? #16

Open
dckc opened this issue Sep 12, 2020 · 2 comments
Open

avoid automatic semicolon insertion (ASI) hazard? #16

dckc opened this issue Sep 12, 2020 · 2 comments

Comments

@dckc
Copy link
Contributor

dckc commented Sep 12, 2020

One of the hazards Agoric left out of Jessie is automatic semicolon insertion.

I'd appreciate it if we could avoid that hazard in this repo; my editors make lots of noise on every line with a missing semicolon at the end.

I tend to follow their style; it's based on airbnb style; the details are in https://github.com/Agoric/new-repo .

@tgrospic
Copy link
Owner

I don't think semicolon is problematic as before. With the use of linters and preprocessors for JS the danger part is eliminated.
https://standardjs.com/rules.html#semicolons

I follow JavaScript Standard Style which has support for VSCode and also other editors.
https://standardjs.com/#are-there-text-editor-plugins

@dckc
Copy link
Contributor Author

dckc commented Sep 14, 2020

OK, using Standard Style does seem to address the ASI hazard.

I thought about closing this now, but I prefer to leave it open until a CI check enforces this style on master.

If you prefer to close this now, I don't mind if you go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants