Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Deploy Code After Changes force queues a deployment even if repo operations fail #87

Open
AffectedArc07 opened this issue Jul 19, 2022 · 3 comments

Comments

@AffectedArc07
Copy link
Member

image

Kinda a pain in the ass UX wise

@Cyberboss
Copy link
Member

Not sure if this is fixable. The idea is we rely on the server side to "queue" the two jobs (deploys can't happen while a repo job is running). This allows the A then B behavior to happen if you close the control panel.

The alternative is to have the panel wait until the repo operation is complete before sending the deploy job. Which is fine, but you miss out on the "async" benefit

@Cyberboss
Copy link
Member

To get perfect behavior we'd have to add server side logic for this, which wouldn't be the end of the world honestly

@AffectedArc07
Copy link
Member Author

Not sure if this is fixable. The idea is we rely on the server side to "queue" the two jobs (deploys can't happen while a repo job is running). This allows the A then B behavior to happen if you close the control panel.

The alternative is to have the panel wait until the repo operation is complete before sending the deploy job. Which is fine, but you miss out on the "async" benefit

I think we lost out on the async benefit anyway when you realise this panel fully locks up every time a web request is made, which is great when your TGS4 host is on the other side of the planet, as well as GitHub being on the other side of the planet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants