Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes on the config.py file and code style #4

Open
ghost opened this issue Sep 28, 2020 · 0 comments
Open

changes on the config.py file and code style #4

ghost opened this issue Sep 28, 2020 · 0 comments

Comments

@ghost
Copy link

ghost commented Sep 28, 2020

Heya 👋

I was about to add a new feature to aura but then I realized the config file was repeating a lot of the code, and I thought of fixing it first.

I've previously made a pr for fixing code style with flake8 and replacing requirements.txt with pipenv (#3). I've seen the review, and I agree with it for the most part, but there is a possibility that the code can be prettified to look better for anyone reading the code.

I want to add the following things:

  • Flake8 - For cleaning up the code and managing type annotations just to make the ide a bit smarter.
  • Pipenv - For adding Flake8 as a dev package (we could use requirements-dev.txt, but pipenv makes it easier)

I've already made a lot of changes in the config.py file: https://hasteb.in/xujubexe.py
I will also reformat all of the code to match the flake8 standards.

Does this sound like a good idea?

@ghost ghost changed the title Discussion for a new pr changes on the config.py file and code style Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants