Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolvers in src/resolvers/authorization.js do not return #64

Open
mambros opened this issue Apr 8, 2019 · 1 comment
Open

Resolvers in src/resolvers/authorization.js do not return #64

mambros opened this issue Apr 8, 2019 · 1 comment
Labels
bug Something isn't working New Edition of Book

Comments

@mambros
Copy link

mambros commented Apr 8, 2019 •
edited
Loading

In my testing of the master branch I found that resolvers isAuthenticated and isAdmin in src/resolvers/authorization.js do not return, and so do not prevent the action their existance was intended to prevent. Perhaps I should create a pull request instead of an "issue"? I am new so please forgive me.
@rwieruch
Copy link
Member

Yes, a pull request would be great! :)

@rwieruch rwieruch added bug Something isn't working New Edition of Book labels May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working New Edition of Book
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rwieruch @mambros