Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Rails 5.1 Compatibility Update #96

Open
JoshuaTatterton opened this issue May 14, 2018 · 1 comment
Open

Refactor Rails 5.1 Compatibility Update #96

JoshuaTatterton opened this issue May 14, 2018 · 1 comment

Comments

@JoshuaTatterton
Copy link
Contributor

JoshuaTatterton commented May 14, 2018

As of the_sortable_tree update which adds the rails 5.1 compatibility. The TheSortableTreeController::DefineDeprecatedMethods module provides the head_respond method that all the methods use.

The TheSortableTreeController::DefineDeprecatedMethods is needed in all other modules but in the current master branch it is not included in the modules that use it. So in implementation you need to include the required modules and the deprecated method module otherwise the other modules will error.

The deprecated methods module should probably be included in any module that use it to streamline implementation. PR incoming.

@yourtallness
Copy link

@JoshuaTatterton Unfortunately, version 2.7.1 which includes this fix has not been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants