Skip to content

Commit 6dcdafe

Browse files
committed
Fix images in PresetPreference
1 parent 9ef85cf commit 6dcdafe

File tree

4 files changed

+21
-17
lines changed

4 files changed

+21
-17
lines changed

app/src/main/java/com/gobbledygook/theawless/eventlock/app/PresetPreference.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ class PresetPreference extends Preference {
1616

1717
public PresetPreference(Context context, AttributeSet attrs) {
1818
super(context, attrs);
19-
TypedArray typedArray = context.obtainStyledAttributes(attrs, R.styleable.PresetPreference, 0, 0);
19+
TypedArray typedArray = context.obtainStyledAttributes(attrs, R.styleable.PresetPreference);
2020
try {
2121
image_res = typedArray.getResourceId(R.styleable.PresetPreference_preset_image, 0);
2222
} finally {
@@ -32,9 +32,13 @@ protected View onCreateView(ViewGroup parent) {
3232
linearLayout.addView(view);
3333
ImageView imageView = new ImageView(parent.getContext());
3434
imageView.setAdjustViewBounds(true);
35-
imageView.setPadding(0, 0, 0, 20);
36-
imageView.setImageResource(image_res);
3735
linearLayout.addView(imageView);
3836
return linearLayout;
3937
}
38+
39+
@Override
40+
protected void onBindView(View view) {
41+
((ImageView) ((LinearLayout) view).getChildAt(1)).setImageResource(image_res);
42+
super.onBindView(view);
43+
}
4044
}

app/src/main/res/values/attrs.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<resources>
33
<declare-styleable name="PresetPreference">
4-
<attr name="preset_image" format="reference" />
4+
<attr name="preset_image" format="integer" />
55
</declare-styleable>
66
</resources>

app/src/main/res/xml/preferences.xml

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
2-
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android">
2+
<PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"
3+
xmlns:app="http://schemas.android.com/apk/res-auto">
34
<PreferenceCategory android:title="@string/settings_title">
45
<com.gobbledygook.theawless.eventlock.app.CalendarPreference
56
android:defaultValue="@array/selected_calendars_default"
@@ -15,38 +16,37 @@
1516
android:title="@string/days_till_title" />
1617
</PreferenceCategory>
1718
<PreferenceCategory android:title="@string/customisation_title">
18-
<PreferenceScreen xmlns:customNS="http://schemas.android.com/apk/res/com.gobbledygook.theawless.eventlock"
19-
android:title="@string/presets_title">
19+
<PreferenceScreen android:title="@string/presets_title">
2020
<PreferenceCategory android:title="@string/multiple_title">
2121
<com.gobbledygook.theawless.eventlock.app.PresetPreference
2222
android:title="@string/multiple_preset1_title"
23-
customNS:preset_image="@drawable/multiple_preset1" />
23+
app:preset_image="@drawable/multiple_preset1" />
2424
<com.gobbledygook.theawless.eventlock.app.PresetPreference
2525
android:title="@string/multiple_preset2_title"
26-
customNS:preset_image="@drawable/multiple_preset2" />
26+
app:preset_image="@drawable/multiple_preset2" />
2727
<com.gobbledygook.theawless.eventlock.app.PresetPreference
2828
android:title="@string/multiple_preset3_title"
29-
customNS:preset_image="@drawable/multiple_preset3" />
29+
app:preset_image="@drawable/multiple_preset3" />
3030
<com.gobbledygook.theawless.eventlock.app.PresetPreference
3131
android:title="@string/multiple_preset4_title"
32-
customNS:preset_image="@drawable/multiple_preset4" />
32+
app:preset_image="@drawable/multiple_preset4" />
3333
<com.gobbledygook.theawless.eventlock.app.PresetPreference
3434
android:title="@string/multiple_preset5_title"
35-
customNS:preset_image="@drawable/multiple_preset5" />
35+
app:preset_image="@drawable/multiple_preset5" />
3636
<com.gobbledygook.theawless.eventlock.app.PresetPreference
3737
android:title="@string/multiple_preset6_title"
38-
customNS:preset_image="@drawable/multiple_preset6" />
38+
app:preset_image="@drawable/multiple_preset6" />
3939
</PreferenceCategory>
4040
<PreferenceCategory android:title="@string/single_title">
4141
<com.gobbledygook.theawless.eventlock.app.PresetPreference
4242
android:title="@string/single_preset1_title"
43-
customNS:preset_image="@drawable/single_preset1" />
43+
app:preset_image="@drawable/single_preset1" />
4444
<com.gobbledygook.theawless.eventlock.app.PresetPreference
4545
android:title="@string/single_preset2_title"
46-
customNS:preset_image="@drawable/single_preset2" />
46+
app:preset_image="@drawable/single_preset2" />
4747
<com.gobbledygook.theawless.eventlock.app.PresetPreference
4848
android:title="@string/single_preset3_title"
49-
customNS:preset_image="@drawable/single_preset3" />
49+
app:preset_image="@drawable/single_preset3" />
5050
</PreferenceCategory>
5151
</PreferenceScreen>
5252
<PreferenceScreen android:title="@string/gismo_title">
@@ -363,7 +363,7 @@
363363
android:title="@string/help_title" />
364364
<Preference
365365
android:summary="@string/project_summary"
366-
android:title="@string/project_title"/>
366+
android:title="@string/project_title" />
367367
<com.gobbledygook.theawless.eventlock.app.VersionPreference android:title="@string/version_title" />
368368
</PreferenceCategory>
369369
</PreferenceScreen>

0 commit comments

Comments
 (0)