Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Same name to be ported using 'as' command #6

Open
pkatuwal opened this issue Aug 17, 2020 · 1 comment
Open

Prevent Same name to be ported using 'as' command #6

pkatuwal opened this issue Aug 17, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@pkatuwal
Copy link

ported using same name on same port

image

Results

No issues on browsing..

Ported Using different name on same port

image

Results

  • No issues on browsing
  • Both Service is running

So Main issue is, when stopping on service which is same name on same port will halt current active service

image

** Left ** and ** Right ** terminal is activated as same name. But Closing Right Terminal request prevent to browse which is valid but showing active on left is not valid.

@thebinary
Copy link
Owner

Actually the newer command run (with same service name) always replaces the older service endpoint. Older local service does not recieve any further requests.

There are 2 possible options I currently see to resolve service name conflict:

  1. Replace older service with newer local endpoint and terminate old processes running in that name
  2. Disallow users to execute new process with service name conflict

I see option 2 to be a better option but I want to give this a bit more thought before implementing. Till then I will keep this issue open.

And this project is open for suggestions too 🙂

@thebinary thebinary added the enhancement New feature or request label Aug 17, 2020
@thebinary thebinary self-assigned this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants