Migrate all "on_delete: :delete_all" calls to the db

Author: jerodsanto

lib/changelog/schema/episode/episode.ex

@@ -82,15 +82,15 @@ defmodule Changelog.Episode do
     belongs_to :podcast, Podcast
     belongs_to :episode_request, EpisodeRequest, foreign_key: :request_id
 
-    has_many :episode_hosts, EpisodeHost, on_delete: :delete_all
+    has_many :episode_hosts, EpisodeHost
     has_many :hosts, through: [:episode_hosts, :person]
-    has_many :episode_guests, EpisodeGuest, on_delete: :delete_all
+    has_many :episode_guests, EpisodeGuest
     has_many :guests, through: [:episode_guests, :person]
-    has_many :episode_topics, EpisodeTopic, on_delete: :delete_all
+    has_many :episode_topics, EpisodeTopic
     has_many :topics, through: [:episode_topics, :topic]
-    has_many :episode_sponsors, EpisodeSponsor, on_delete: :delete_all
+    has_many :episode_sponsors, EpisodeSponsor
     has_many :sponsors, through: [:episode_sponsors, :sponsor]
-    has_many :episode_stats, EpisodeStat, on_delete: :delete_all
+    has_many :episode_stats, EpisodeStat
 
     timestamps()
   end

lib/changelog/schema/news/news_ad.ex

@@ -18,7 +18,7 @@ defmodule Changelog.NewsAd do
     field :delete, :boolean, virtual: true
 
     belongs_to :sponsorship, NewsSponsorship
-    has_many :news_issue_ads, NewsIssueAd, foreign_key: :ad_id, on_delete: :delete_all
+    has_many :news_issue_ads, NewsIssueAd, foreign_key: :ad_id
     has_many :issues, through: [:news_issue_ads, :issue]
 
     timestamps()

lib/changelog/schema/news/news_issue.ex

@@ -11,9 +11,9 @@ defmodule Changelog.NewsIssue do
     field :published, :boolean, default: false
     field :published_at, :utc_datetime
 
-    has_many :news_issue_ads, NewsIssueAd, foreign_key: :issue_id, on_delete: :delete_all
+    has_many :news_issue_ads, NewsIssueAd, foreign_key: :issue_id
     has_many :ads, through: [:news_issue_ads, :ad]
-    has_many :news_issue_items, NewsIssueItem, foreign_key: :issue_id, on_delete: :delete_all
+    has_many :news_issue_items, NewsIssueItem, foreign_key: :issue_id
     has_many :items, through: [:news_issue_items, :item]
 
     timestamps()

lib/changelog/schema/news/news_item.ex

@@ -47,15 +47,12 @@ defmodule Changelog.NewsItem do
     belongs_to :logger, Person
     belongs_to :submitter, Person
     belongs_to :source, NewsSource
-    has_one :news_queue, NewsQueue, foreign_key: :item_id, on_delete: :delete_all
+    has_one :news_queue, NewsQueue, foreign_key: :item_id
 
-    has_many :news_item_topics, NewsItemTopic,
-      foreign_key: :item_id,
-      on_delete: :delete_all,
-      on_replace: :delete
+    has_many :news_item_topics, NewsItemTopic, foreign_key: :item_id, on_replace: :delete
 
     has_many :topics, through: [:news_item_topics, :topic]
-    has_many :comments, NewsItemComment, foreign_key: :item_id, on_delete: :delete_all
+    has_many :comments, NewsItemComment, foreign_key: :item_id
     has_many :subscriptions, Subscription, where: [unsubscribed_at: nil], foreign_key: :item_id
 
     timestamps()

lib/changelog/schema/news/news_sponsorship.ex

@@ -10,7 +10,7 @@ defmodule Changelog.NewsSponsorship do
     field :click_count, :integer, default: 0
 
     belongs_to :sponsor, Sponsor
-    has_many :ads, NewsAd, foreign_key: :sponsorship_id, on_delete: :delete_all
+    has_many :ads, NewsAd, foreign_key: :sponsorship_id
 
     timestamps()
   end

lib/changelog/schema/person.ex

@@ -77,26 +77,26 @@ defmodule Changelog.Person do
     has_many :memberships, Membership
     has_one :active_membership, Membership, where: [status: {:in, Membership.active_statuses()}]
 
-    has_many :podcast_hosts, PodcastHost, on_delete: :delete_all
+    has_many :podcast_hosts, PodcastHost
 
-    has_many :episode_hosts, EpisodeHost, on_delete: :delete_all
+    has_many :episode_hosts, EpisodeHost
     has_many :host_episodes, through: [:episode_hosts, :episode]
 
-    has_many :episode_guests, EpisodeGuest, on_delete: :delete_all
+    has_many :episode_guests, EpisodeGuest
     has_many :guest_episodes, through: [:episode_guests, :episode]
 
-    has_many :authored_posts, Post, foreign_key: :author_id, on_delete: :delete_all
+    has_many :authored_posts, Post, foreign_key: :author_id
 
-    has_many :sponsor_reps, SponsorRep, on_delete: :delete_all
+    has_many :sponsor_reps, SponsorRep
     has_many :sponsors, through: [:sponsor_reps, :sponsor]
 
     has_many :authored_news_items, NewsItem, foreign_key: :author_id, on_delete: :nilify_all
     has_many :logged_news_items, NewsItem, foreign_key: :logger_id, on_delete: :nilify_all
     has_many :submitted_news_items, NewsItem, foreign_key: :submitter_id, on_delete: :nilify_all
 
     has_many :comments, NewsItemComment, foreign_key: :author_id
-    has_many :subscriptions, Subscription, where: [unsubscribed_at: nil], on_delete: :delete_all
-    has_many :episode_requests, EpisodeRequest, foreign_key: :submitter_id, on_delete: :delete_all
+    has_many :subscriptions, Subscription, where: [unsubscribed_at: nil]
+    has_many :episode_requests, EpisodeRequest, foreign_key: :submitter_id
 
     has_many :feeds, Feed, foreign_key: :owner_id
 

lib/changelog/schema/podcast/podcast.ex

@@ -51,12 +51,12 @@ defmodule Changelog.Podcast do
 
     field :cover, Files.Cover.Type
 
-    has_many :episodes, Episode, on_delete: :delete_all
-    has_many :episode_requests, EpisodeRequest, on_delete: :delete_all
-    has_many :podcast_topics, PodcastTopic, on_delete: :delete_all
+    has_many :episodes, Episode
+    has_many :episode_requests, EpisodeRequest
+    has_many :podcast_topics, PodcastTopic
     has_many :topics, through: [:podcast_topics, :topic]
 
-    has_many :podcast_hosts, PodcastHost, on_delete: :delete_all
+    has_many :podcast_hosts, PodcastHost
     has_many :hosts, through: [:podcast_hosts, :person]
 
     has_many :active_podcast_hosts, PodcastHost, where: [retired: false]

lib/changelog/schema/post/post.ex

@@ -26,7 +26,7 @@ defmodule Changelog.Post do
     belongs_to :author, Person
     belongs_to :editor, Person
 
-    has_many :post_topics, PostTopic, on_delete: :delete_all
+    has_many :post_topics, PostTopic
     has_many :topics, through: [:post_topics, :topic]
 
     timestamps()

lib/changelog/schema/sponsor/sponsor.ex

@@ -15,10 +15,10 @@ defmodule Changelog.Sponsor do
     field :dark_logo, Files.DarkLogo.Type
     field :light_logo, Files.LightLogo.Type
 
-    has_many :episode_sponsors, EpisodeSponsor, on_delete: :delete_all
-    has_many :news_sponsorships, NewsSponsorship, on_delete: :delete_all
+    has_many :episode_sponsors, EpisodeSponsor
+    has_many :news_sponsorships, NewsSponsorship
 
-    has_many :sponsor_reps, SponsorRep, on_delete: :delete_all
+    has_many :sponsor_reps, SponsorRep
     has_many :reps, through: [:sponsor_reps, :person]
 
     timestamps()

lib/changelog/schema/topic.ex

@@ -12,11 +12,11 @@ defmodule Changelog.Topic do
 
     field :icon, Files.Icon.Type
 
-    has_many :episode_topics, EpisodeTopic, on_delete: :delete_all
+    has_many :episode_topics, EpisodeTopic
     has_many :episodes, through: [:episode_topics, :episode]
-    has_many :news_item_topics, NewsItemTopic, on_delete: :delete_all
+    has_many :news_item_topics, NewsItemTopic
     has_many :news_items, through: [:news_item_topics, :news_item]
-    has_many :post_topics, PostTopic, on_delete: :delete_all
+    has_many :post_topics, PostTopic
     has_many :posts, through: [:post_topics, :post]
 
     timestamps()

priv/repo/migrations/20241024142033_move_delete_alls_to_database.exs

@@ -0,0 +1,39 @@
+defmodule Changelog.Repo.Migrations.MoveDeleteAllsToDatabase do
+  use Ecto.Migration
+
+  def up do
+    drop constraint(:feed_stats, :feed_stats_feed_id_fkey)
+
+    alter table(:feed_stats) do
+      modify(:feed_id, references(:feeds, on_delete: :delete_all))
+    end
+
+    drop constraint(:news_item_comments, :news_item_comments_item_id_fkey)
+
+    alter table(:news_item_comments) do
+      modify(:item_id, references(:news_items, on_delete: :delete_all))
+    end
+
+    drop constraint(:news_ads, :news_ads_sponsorship_id_fkey)
+
+    alter table(:news_ads) do
+      modify(:sponsorship_id, references(:news_sponsorships, on_delete: :delete_all))
+    end
+
+    drop constraint(:sponsor_reps, :sponsor_reps_sponsor_id_fkey)
+
+    alter table(:sponsor_reps) do
+      modify(:sponsor_id, references(:sponsors, on_delete: :delete_all))
+    end
+
+    drop constraint(:sponsor_reps, :sponsor_reps_person_id_fkey)
+
+    alter table(:sponsor_reps) do
+      modify(:person_id, references(:people, on_delete: :delete_all))
+    end
+  end
+
+  def down do
+    # do nothing because the `up` is idempotent
+  end
+end