Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 'static' instead of 'self' in static returning methods #284

Open
wants to merge 1 commit into
base: 5.3
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ResultIterator.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ final private function __construct()
* @param mixed[] $parameters
* @param class-string|null $className
*/
public static function createResultIterator(QueryFactory $queryFactory, array $parameters, ObjectStorageInterface $objectStorage, ?string $className, TDBMService $tdbmService, MagicQuery $magicQuery, int $mode, LoggerInterface $logger): self
public static function createResultIterator(QueryFactory $queryFactory, array $parameters, ObjectStorageInterface $objectStorage, ?string $className, TDBMService $tdbmService, MagicQuery $magicQuery, int $mode, LoggerInterface $logger): static
{
$iterator = new static();
if ($mode !== TDBMService::MODE_CURSOR && $mode !== TDBMService::MODE_ARRAY) {
Expand All @@ -99,7 +99,7 @@ public static function createResultIterator(QueryFactory $queryFactory, array $p
return $iterator;
}

public static function createEmpyIterator(): self
public static function createEmpyIterator(): static
{
$iterator = new static();
$iterator->totalCount = 0;
Expand Down
Loading